From: Pedro Alves <palves@redhat.com>
To: "Metzger, Markus T" <markus.t.metzger@intel.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: "set record instruction-history" ?
Date: Wed, 27 Mar 2013 11:23:00 -0000 [thread overview]
Message-ID: <5152BCB3.5030405@redhat.com> (raw)
In-Reply-To: <A78C989F6D9628469189715575E55B2307BA8B86@IRSMSX102.ger.corp.intel.com>
On 03/27/2013 07:53 AM, Metzger, Markus T wrote:
> There is a single regression...
:-(
> record: fix instruction-history-size regression
>
> (gdb) PASS: gdb.btrace/instruction_history.exp: set record instruction-history-size 0
> record instruction-history 0
> Bad range.
> (gdb) FAIL: gdb.btrace/instruction_history.exp: record instruction-history - unlimited
>
> 2013-03-13 Markus Metzger <markus.t.metzger@intel.com>
>
> * record.c (command_size_to_target_size): Fix size comparison.
> Change parameter type from pointer to integer to integer.
> Update all users.
> OK to commit?
Certainly. Thanks for fixing this up.
> Does this also go onto the 7.6 branch?
Mine's not on 7.6 yet. I'll take care of that.
I'm going through all commands (and almost done at that) and will
look over all changes and merge back to 7.6 those that make sense.
--
Pedro Alves
prev parent reply other threads:[~2013-03-27 9:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 17:23 Pedro Alves
2013-03-25 17:25 ` Metzger, Markus T
2013-03-25 19:55 ` Pedro Alves
2013-03-26 16:21 ` Metzger, Markus T
2013-03-26 16:53 ` Pedro Alves
2013-03-26 16:58 ` Metzger, Markus T
2013-03-26 19:35 ` Pedro Alves
2013-03-27 10:03 ` Metzger, Markus T
2013-03-27 11:23 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5152BCB3.5030405@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox