From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10749 invoked by alias); 27 Mar 2013 09:32:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10730 invoked by uid 89); 27 Mar 2013 09:32:43 -0000 X-Spam-SWARE-Status: No, score=-8.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 27 Mar 2013 09:32:39 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2R9WbPs018333 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 27 Mar 2013 05:32:37 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r2R9WahP001892; Wed, 27 Mar 2013 05:32:36 -0400 Message-ID: <5152BCB3.5030405@redhat.com> Date: Wed, 27 Mar 2013 11:23:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: "Metzger, Markus T" CC: GDB Patches Subject: Re: "set record instruction-history" ? References: <51507403.6030208@redhat.com> <51508D60.6040906@redhat.com> <5151836D.90401@redhat.com> <5151E3BE.90603@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-03/txt/msg01009.txt.bz2 On 03/27/2013 07:53 AM, Metzger, Markus T wrote: > There is a single regression... :-( > record: fix instruction-history-size regression > > (gdb) PASS: gdb.btrace/instruction_history.exp: set record instruction-history-size 0 > record instruction-history 0 > Bad range. > (gdb) FAIL: gdb.btrace/instruction_history.exp: record instruction-history - unlimited > > 2013-03-13 Markus Metzger > > * record.c (command_size_to_target_size): Fix size comparison. > Change parameter type from pointer to integer to integer. > Update all users. > OK to commit? Certainly. Thanks for fixing this up. > Does this also go onto the 7.6 branch? Mine's not on 7.6 yet. I'll take care of that. I'm going through all commands (and almost done at that) and will look over all changes and merge back to 7.6 those that make sense. -- Pedro Alves