From: Pedro Alves <palves@redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: "gdb-patches@sourceware.org ml" <gdb-patches@sourceware.org>
Subject: Re: [RFA] Stop leaking extra_string
Date: Wed, 20 Mar 2013 19:23:00 -0000 [thread overview]
Message-ID: <514A0A9E.1090105@redhat.com> (raw)
In-Reply-To: <514A08A5.6020504@redhat.com>
On 03/20/2013 07:06 PM, Keith Seitz wrote:
> ChangeLog
> 2013-03-20 Keith Seitz <keiths@redhat.com>
>
> * breakpoint.h (struct breakpoint): Add comment to
> extra_string indicating that this member is mallod'd.
> * breakpoint.c (base_breakpoint_dtor): Free extra_string.
This is fine, thanks.
When we get to this bit in addr_string_to_sals (called through
breakpoint_re_set_default):
if (cond_string)
b->cond_string = cond_string;
b->thread = thread;
b->task = task;
if (extra_string)
b->extra_string = extra_string;
b->condition_not_parsed = 0;
Is b->extra_string always NULL here, or could we be
leaking it here too?
--
Pedro Alves
next prev parent reply other threads:[~2013-03-20 19:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 19:14 Keith Seitz
2013-03-20 19:23 ` Pedro Alves [this message]
2013-03-21 0:42 ` Keith Seitz
2013-03-22 20:13 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514A0A9E.1090105@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox