From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3005 invoked by alias); 20 Mar 2013 19:14:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2983 invoked by uid 89); 20 Mar 2013 19:14:44 -0000 X-Spam-SWARE-Status: No, score=-8.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 20 Mar 2013 19:14:41 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2KJEeQj017235 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 20 Mar 2013 15:14:40 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r2KJEdVB027818; Wed, 20 Mar 2013 15:14:39 -0400 Message-ID: <514A0A9E.1090105@redhat.com> Date: Wed, 20 Mar 2013 19:23:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Keith Seitz CC: "gdb-patches@sourceware.org ml" Subject: Re: [RFA] Stop leaking extra_string References: <514A08A5.6020504@redhat.com> In-Reply-To: <514A08A5.6020504@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-03/txt/msg00767.txt.bz2 On 03/20/2013 07:06 PM, Keith Seitz wrote: > ChangeLog > 2013-03-20 Keith Seitz > > * breakpoint.h (struct breakpoint): Add comment to > extra_string indicating that this member is mallod'd. > * breakpoint.c (base_breakpoint_dtor): Free extra_string. This is fine, thanks. When we get to this bit in addr_string_to_sals (called through breakpoint_re_set_default): if (cond_string) b->cond_string = cond_string; b->thread = thread; b->task = task; if (extra_string) b->extra_string = extra_string; b->condition_not_parsed = 0; Is b->extra_string always NULL here, or could we be leaking it here too? -- Pedro Alves