Re: [RFC/RFA PATCH] Constify strings in tracepoint.c, lookup_cmd and the completers.

[Keith Seitz <keiths@redhat.com>]

On 03/13/2013 05:32 AM, Pedro Alves wrote:
> This is sort of a continuation of Keith's parse_exp_1 constification
> patch.

Super!

> That ended up constifying lookup_cmd/add_cmd and (lots of) friends,
> and the completers.

Excellent. That's the one area I didn't get around to touching.

> I didn't try to constify the command hooks themselves, because I know
> upfront there are commands that write to the command string argument,
> and I think I managed to stop at a nice non-hacky split point already.

Yeah, there are a lot of places where "goofy" (old-skool?) stuff like 
this happens, e.g., strip_bg_char. Yick.

> I think the only non-really-super-obvious changes are
> tracepoint.c:validate_actionline, and tracepoint.c:trace_dump_actions.

Those look okay to me.

The only thing "wrong" that I found was missing comment on the new 
output_command_const; just to be maintainer-pedantic (even though I am 
not a maintainer). :-P

I say, commit it!

When I'm done rebasing my current work, I'll see if I can dig up the 
rest of my patches on this subject.

Keith