From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17145 invoked by alias); 13 Mar 2013 17:22:52 -0000 Received: (qmail 17134 invoked by uid 22791); 13 Mar 2013 17:22:51 -0000 X-SWARE-Spam-Status: No, hits=-8.1 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Mar 2013 17:22:44 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2DHMiHI008753 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 13 Mar 2013 13:22:44 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r2DHMgso031252 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 13 Mar 2013 13:22:44 -0400 Message-ID: <5140B5E2.7010701@redhat.com> Date: Wed, 13 Mar 2013 17:22:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: Pedro Alves CC: gdb-patches@sourceware.org Subject: Re: [RFC/RFA PATCH] Constify strings in tracepoint.c, lookup_cmd and the completers. References: <20130313123205.31184.43525.stgit@brno.lan> In-Reply-To: <20130313123205.31184.43525.stgit@brno.lan> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00580.txt.bz2 On 03/13/2013 05:32 AM, Pedro Alves wrote: > This is sort of a continuation of Keith's parse_exp_1 constification > patch. Super! > That ended up constifying lookup_cmd/add_cmd and (lots of) friends, > and the completers. Excellent. That's the one area I didn't get around to touching. > I didn't try to constify the command hooks themselves, because I know > upfront there are commands that write to the command string argument, > and I think I managed to stop at a nice non-hacky split point already. Yeah, there are a lot of places where "goofy" (old-skool?) stuff like this happens, e.g., strip_bg_char. Yick. > I think the only non-really-super-obvious changes are > tracepoint.c:validate_actionline, and tracepoint.c:trace_dump_actions. Those look okay to me. The only thing "wrong" that I found was missing comment on the new output_command_const; just to be maintainer-pedantic (even though I am not a maintainer). :-P I say, commit it! When I'm done rebasing my current work, I'll see if I can dig up the rest of my patches on this subject. Keith