Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA PATCH] Fix --dynamic-list test's workaround for http://bugs.python.org/issue4434.
Date: Mon, 11 Mar 2013 18:35:00 -0000	[thread overview]
Message-ID: <513E23F5.5000702@redhat.com> (raw)
In-Reply-To: <20130311181407.GA24981@host2.jankratochvil.net>

On 03/11/2013 06:14 PM, Jan Kratochvil wrote:
> On Fri, 08 Mar 2013 00:14:00 +0100, Pedro Alves wrote:
>> After a chat on IRC, I noticed that my gdb binary was linking with
>> -Wl,--export-dynamic instead of the better -Wl,--dynamic-list.
> 
> I agree with this fix (with the bit LDFLAGS -> LIBS).

Ah yes, LIBS, of course.  Please go ahead.

> 
> But in practice it does not change anything as the full linking commandline
> also contains
> 	LINKFORSHARED=-Xlinker -export-dynamic
> from
> 	/usr/lib/python2.7/config/Makefile
> which overrides it:
> 	../readline/libreadline.a ../opcodes/libopcodes.a ../bfd/libbfd.a  ../libiberty/libiberty.a ../libdecnumber/libdecnumber.a    -ldl -ldl -lncurses -lz -lm    -lpthread -ldl -lutil -lm -lpython2.7 -Xlinker -export-dynamic -lexpat -llzma ../libiberty/libiberty.a  build-gnulib/import/libgnu.a -ldl -Wl,--dynamic-list=./proc-service.list

Bummer.

> The real fix to reduce the stripped GDB binary by 1MB of .dynsym back again
> after it was regressed by Python would be to drop gdb/proc-service.list, add
> gcc parameter -fvisibility=hidden and mark all the exported symbols (currently
> in gdb/proc-service.list) by __attribute__ ((visibility ("default"))).
> 
> At least I hope that -fvisibility=hidden won't break Python on the other hand.

Did you try:

- RDYNAMIC='-Wl,--dynamic-list=$(srcdir)/proc-service.list'
+ RDYNAMIC='-Wl,--no-export-dynamic -Wl,--dynamic-list=$(srcdir)/proc-service.list'

?

-- 
Pedro Alves


  reply	other threads:[~2013-03-11 18:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-07 23:14 Pedro Alves
2013-03-11 18:14 ` Jan Kratochvil
2013-03-11 18:35   ` Pedro Alves [this message]
2013-03-11 18:52     ` [commit] " Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=513E23F5.5000702@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox