From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28673 invoked by alias); 11 Mar 2013 18:35:41 -0000 Received: (qmail 28544 invoked by uid 22791); 11 Mar 2013 18:35:40 -0000 X-SWARE-Spam-Status: No, hits=-8.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_LN X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 11 Mar 2013 18:35:35 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2BIZYnh016612 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 11 Mar 2013 14:35:34 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r2BIZXJE009570; Mon, 11 Mar 2013 14:35:34 -0400 Message-ID: <513E23F5.5000702@redhat.com> Date: Mon, 11 Mar 2013 18:35:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130219 Thunderbird/17.0.3 MIME-Version: 1.0 To: Jan Kratochvil CC: gdb-patches@sourceware.org Subject: Re: [RFA PATCH] Fix --dynamic-list test's workaround for http://bugs.python.org/issue4434. References: <20130307231400.13859.88836.stgit@brno.lan> <20130311181407.GA24981@host2.jankratochvil.net> In-Reply-To: <20130311181407.GA24981@host2.jankratochvil.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00484.txt.bz2 On 03/11/2013 06:14 PM, Jan Kratochvil wrote: > On Fri, 08 Mar 2013 00:14:00 +0100, Pedro Alves wrote: >> After a chat on IRC, I noticed that my gdb binary was linking with >> -Wl,--export-dynamic instead of the better -Wl,--dynamic-list. > > I agree with this fix (with the bit LDFLAGS -> LIBS). Ah yes, LIBS, of course. Please go ahead. > > But in practice it does not change anything as the full linking commandline > also contains > LINKFORSHARED=-Xlinker -export-dynamic > from > /usr/lib/python2.7/config/Makefile > which overrides it: > ../readline/libreadline.a ../opcodes/libopcodes.a ../bfd/libbfd.a ../libiberty/libiberty.a ../libdecnumber/libdecnumber.a -ldl -ldl -lncurses -lz -lm -lpthread -ldl -lutil -lm -lpython2.7 -Xlinker -export-dynamic -lexpat -llzma ../libiberty/libiberty.a build-gnulib/import/libgnu.a -ldl -Wl,--dynamic-list=./proc-service.list Bummer. > The real fix to reduce the stripped GDB binary by 1MB of .dynsym back again > after it was regressed by Python would be to drop gdb/proc-service.list, add > gcc parameter -fvisibility=hidden and mark all the exported symbols (currently > in gdb/proc-service.list) by __attribute__ ((visibility ("default"))). > > At least I hope that -fvisibility=hidden won't break Python on the other hand. Did you try: - RDYNAMIC='-Wl,--dynamic-list=$(srcdir)/proc-service.list' + RDYNAMIC='-Wl,--no-export-dynamic -Wl,--dynamic-list=$(srcdir)/proc-service.list' ? -- Pedro Alves