From: Pedro Alves <palves@redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: "gdb-patches@sourceware.org ml" <gdb-patches@sourceware.org>
Subject: Re: [RFA] Constify gen_printf/ax_string
Date: Wed, 06 Mar 2013 20:11:00 -0000 [thread overview]
Message-ID: <5137A2F2.6050308@redhat.com> (raw)
In-Reply-To: <51379F85.4050005@redhat.com>
On 03/06/2013 07:56 PM, Keith Seitz wrote:
> Hi,
>
> As a follow-up to my "constify find_condition_and_thread" patch, which I am withdrawing, I will be submitting a patch to constify parse_exp_1. This patch is the only cleanup that I could split up off that (much larger) patch.
>
> Even if that approach is not liked/desired by maintainers, this patch has its own merit IMO.
I can't begin to imagine how to object to this one. :-)
> Tested by rebuilding (and testing on native-gdbserver, however fruitless that is on this type of patch).
> ChangeLog
> 2013-03-06 Keith Seitz <keiths@redhat.com>
>
> * ax-gdb.c (gen_printf): Make FORMAT const.
> * ax-gdb.h (gen_printf): Likewise.
> * ax-general.c (ax_string): Make STR const.
> * ax.h (ax_string): Likewise.
OK.
--
Pedro Alves
next prev parent reply other threads:[~2013-03-06 20:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 19:57 Keith Seitz
2013-03-06 20:11 ` Pedro Alves [this message]
2013-03-07 0:49 ` Keith Seitz
2013-03-06 21:51 ` Tom Tromey
2013-03-06 21:57 ` Keith Seitz
2013-03-07 15:04 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5137A2F2.6050308@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox