From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7436 invoked by alias); 6 Mar 2013 20:11:40 -0000 Received: (qmail 7425 invoked by uid 22791); 6 Mar 2013 20:11:39 -0000 X-SWARE-Spam-Status: No, hits=-8.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Mar 2013 20:11:34 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r26KBWxf014859 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 6 Mar 2013 15:11:32 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r26KBUS4025766; Wed, 6 Mar 2013 15:11:31 -0500 Message-ID: <5137A2F2.6050308@redhat.com> Date: Wed, 06 Mar 2013 20:11:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130219 Thunderbird/17.0.3 MIME-Version: 1.0 To: Keith Seitz CC: "gdb-patches@sourceware.org ml" Subject: Re: [RFA] Constify gen_printf/ax_string References: <51379F85.4050005@redhat.com> In-Reply-To: <51379F85.4050005@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00229.txt.bz2 On 03/06/2013 07:56 PM, Keith Seitz wrote: > Hi, > > As a follow-up to my "constify find_condition_and_thread" patch, which I am withdrawing, I will be submitting a patch to constify parse_exp_1. This patch is the only cleanup that I could split up off that (much larger) patch. > > Even if that approach is not liked/desired by maintainers, this patch has its own merit IMO. I can't begin to imagine how to object to this one. :-) > Tested by rebuilding (and testing on native-gdbserver, however fruitless that is on this type of patch). > ChangeLog > 2013-03-06 Keith Seitz > > * ax-gdb.c (gen_printf): Make FORMAT const. > * ax-gdb.h (gen_printf): Likewise. > * ax-general.c (ax_string): Make STR const. > * ax.h (ax_string): Likewise. OK. -- Pedro Alves