From: Yao Qi <yao@codesourcery.com>
To: Pedro Alves <palves@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix a bug in tstatus.exp matching tstatus output
Date: Tue, 05 Mar 2013 02:39:00 -0000 [thread overview]
Message-ID: <51355AC1.1080000@codesourcery.com> (raw)
In-Reply-To: <5134CC91.804@redhat.com>
On 03/05/2013 12:32 AM, Pedro Alves wrote:
> On 03/04/2013 03:35 PM, Yao Qi wrote:
>> (gdb) PASS: gdb.trace/tstatus.exp: tstatus does not report trace stop reason
> ...
>> (gdb) PASS: gdb.trace/tstatus.exp: tstatus reports trace stop reason
>
> I think the former (and any other similar case) should be
> UNSUPPORTED rather than a PASS. That'd make it much easier
> to spot these issues, along with regressions and progressions.
>
Several lines above, the comments say:
# Now play with tstatus a bit.
# Since note support is optional, we need to match both with and without
# cases.
so all tests below here match two cases (with and without notes). I am
not sure we can change it to UNSUPPORTED, but it is not the purpose or
motivation of this patch. It can be addressed separately.
--
Yao (é½å°§)
next prev parent reply other threads:[~2013-03-05 2:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 15:37 Yao Qi
2013-03-04 16:23 ` Joel Brobecker
2013-03-04 17:35 ` Tom Tromey
2013-03-05 2:24 ` Yao Qi
2013-03-05 19:09 ` Pedro Alves
2013-03-04 16:32 ` Pedro Alves
2013-03-05 2:39 ` Yao Qi [this message]
2013-03-05 19:02 ` tstatus.exp: use UNSUPPORTED for optional features that are not supported (was: Re: [PATCH] Fix a bug in tstatus.exp matching tstatus output) Pedro Alves
2013-03-06 1:14 ` tstatus.exp: use UNSUPPORTED for optional features that are not supported Yao Qi
2013-03-06 12:19 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51355AC1.1080000@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox