From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25754 invoked by alias); 5 Mar 2013 02:39:48 -0000 Received: (qmail 25632 invoked by uid 22791); 5 Mar 2013 02:39:47 -0000 X-SWARE-Spam-Status: No, hits=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 05 Mar 2013 02:39:43 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1UChn4-0002ze-Az from Yao_Qi@mentor.com ; Mon, 04 Mar 2013 18:39:42 -0800 Received: from SVR-ORW-FEM-05.mgc.mentorg.com ([147.34.97.43]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 4 Mar 2013 18:39:41 -0800 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.1.289.1; Mon, 4 Mar 2013 18:39:41 -0800 Message-ID: <51355AC1.1080000@codesourcery.com> Date: Tue, 05 Mar 2013 02:39:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Pedro Alves CC: Subject: Re: [PATCH] Fix a bug in tstatus.exp matching tstatus output References: <1362411345-22308-1-git-send-email-yao@codesourcery.com> <5134CC91.804@redhat.com> In-Reply-To: <5134CC91.804@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00133.txt.bz2 On 03/05/2013 12:32 AM, Pedro Alves wrote: > On 03/04/2013 03:35 PM, Yao Qi wrote: >> (gdb) PASS: gdb.trace/tstatus.exp: tstatus does not report trace stop reason > ... >> (gdb) PASS: gdb.trace/tstatus.exp: tstatus reports trace stop reason > > I think the former (and any other similar case) should be > UNSUPPORTED rather than a PASS. That'd make it much easier > to spot these issues, along with regressions and progressions. > Several lines above, the comments say: # Now play with tstatus a bit. # Since note support is optional, we need to match both with and without # cases. so all tests below here match two cases (with and without notes). I am not sure we can change it to UNSUPPORTED, but it is not the purpose or motivation of this patch. It can be addressed separately. -- Yao (齐尧)