Re: [PATCH] Support targets that know how to continue over breakpoints[2/4] -- Doc

[Hui Zhu <hui_zhu@mentor.com>]

[-- Attachment #1: Type: text/plain, Size: 1711 bytes --]

Hi Eli,

Thanks for your review.

Post a new version according to your comments.

Best,
Hui

On 03/03/13 00:18, Eli Zaretskii wrote:
>> Date: Sun, 3 Mar 2013 00:11:27 +0800
>> From: Hui Zhu <hui_zhu@mentor.com>
>> CC: <lgustavo@codesourcery.com>, Pedro Alves <palves@redhat.com>, Eli
>>   Zaretskii <eliz@gnu.org>
>>
>> This is the doc patch for continue over breakpoints function.
>
> Thanks.
>
>> +@item ContinueOverBreakpoints
>> +The remote stub knows how to continue over breakpoints itself.
>
> Please remove the "itself" part, it is not needed.
>
>>                                                                  If this
>> +feature is supported by the target, then @value{GDBN} does not need to
>> +lift breakpoints off of the inferior and step over them.  This feature
>
>   "... @value{GDBN} does not need to remove breakpoints in order to
>   step over them."
>
>
>> +only applies to continue requests. This feature is only defined when the
>                                      ^^                     ^^^^^^^
> Two spaces here.  And "available" instead of "defined".
>
>> +remote stub supports managing breakpoints itself (see @ref{insert
>> +breakpoint or watchpoint packet}).
>
> Please use "@pxref" instead of "see @ref".
>
>>                                     @value{GDBN} assumes that this feature
>> +is applicable to all breakpoints types supported by the stub.
>                          ^^^^^^^^^^^
> "breakpoint", in singular.
>
> OK with those changes.
>


2013-03-03  Luis Machado  <lgustavo@codesourcery.com>
	    Pedro Alves  <pedro@codesourcery.com>
	    Hui Zhu  <hui_zhu@mentor.com>

	* gdb.texinfo (General Query Packets): Document
	ContinueOverBreakpoints under qSupported.


[-- Attachment #2: remote-cob-doc.txt --]
[-- Type: text/plain, Size: 1022 bytes --]

--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -37383,6 +37383,11 @@ These are the currently defined stub fea
 @tab @samp{-}
 @tab No
 
+@item @samp{ContinueOverBreakpoints}
+@tab No
+@tab @samp{-}
+@tab No
+
 @end multitable
 
 These are the currently defined stub features, in more detail:
@@ -37537,6 +37542,15 @@ See @ref{Bytecode Descriptions} for deta
 The remote stub supports running a breakpoint's command list itself,
 rather than reporting the hit to @value{GDBN}.
 
+@item ContinueOverBreakpoints
+The remote stub knows how to continue over breakpoints.  If this
+feature is supported by the target, then @value{GDBN} does not
+remove breakpoints in order to step over them.  This feature
+only applies to continue requests.  This feature is only available
+when the remote stub supports managing breakpoints itself (@pxref{insert
+breakpoint or watchpoint packet}).  @value{GDBN} assumes that
+this feature is applicable to all breakpoint types supported by the stub.
+
 @end table
 
 @item qSymbol::