From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9952 invoked by alias); 3 Mar 2013 02:06:33 -0000 Received: (qmail 9858 invoked by uid 22791); 3 Mar 2013 02:06:32 -0000 X-SWARE-Spam-Status: No, hits=-4.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 03 Mar 2013 02:06:27 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1UByJj-00063Q-N6 from Hui_Zhu@mentor.com ; Sat, 02 Mar 2013 18:06:23 -0800 Received: from SVR-ORW-FEM-05.mgc.mentorg.com ([147.34.97.43]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Sat, 2 Mar 2013 18:06:23 -0800 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.1.289.1; Sat, 2 Mar 2013 18:06:22 -0800 Message-ID: <5132B01A.8070903@mentor.com> Date: Sun, 03 Mar 2013 02:06:00 -0000 From: Hui Zhu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0 MIME-Version: 1.0 To: Eli Zaretskii CC: , , Subject: Re: [PATCH] Support targets that know how to continue over breakpoints[2/4] -- Doc References: <51322425.6090007@mentor.com> <513224AF.6030603@mentor.com> <8338wdvkpl.fsf@gnu.org> In-Reply-To: <8338wdvkpl.fsf@gnu.org> Content-Type: multipart/mixed; boundary="------------050003060601050504010807" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00064.txt.bz2 --------------050003060601050504010807 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Content-length: 1711 Hi Eli, Thanks for your review. Post a new version according to your comments. Best, Hui On 03/03/13 00:18, Eli Zaretskii wrote: >> Date: Sun, 3 Mar 2013 00:11:27 +0800 >> From: Hui Zhu >> CC: , Pedro Alves , Eli >> Zaretskii >> >> This is the doc patch for continue over breakpoints function. > > Thanks. > >> +@item ContinueOverBreakpoints >> +The remote stub knows how to continue over breakpoints itself. > > Please remove the "itself" part, it is not needed. > >> If this >> +feature is supported by the target, then @value{GDBN} does not need to >> +lift breakpoints off of the inferior and step over them. This feature > > "... @value{GDBN} does not need to remove breakpoints in order to > step over them." > > >> +only applies to continue requests. This feature is only defined when the > ^^ ^^^^^^^ > Two spaces here. And "available" instead of "defined". > >> +remote stub supports managing breakpoints itself (see @ref{insert >> +breakpoint or watchpoint packet}). > > Please use "@pxref" instead of "see @ref". > >> @value{GDBN} assumes that this feature >> +is applicable to all breakpoints types supported by the stub. > ^^^^^^^^^^^ > "breakpoint", in singular. > > OK with those changes. > 2013-03-03 Luis Machado Pedro Alves Hui Zhu * gdb.texinfo (General Query Packets): Document ContinueOverBreakpoints under qSupported. --------------050003060601050504010807 Content-Type: text/plain; charset="us-ascii"; name="remote-cob-doc.txt" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="remote-cob-doc.txt" Content-length: 1022 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -37383,6 +37383,11 @@ These are the currently defined stub fea @tab @samp{-} @tab No +@item @samp{ContinueOverBreakpoints} +@tab No +@tab @samp{-} +@tab No + @end multitable These are the currently defined stub features, in more detail: @@ -37537,6 +37542,15 @@ See @ref{Bytecode Descriptions} for deta The remote stub supports running a breakpoint's command list itself, rather than reporting the hit to @value{GDBN}. +@item ContinueOverBreakpoints +The remote stub knows how to continue over breakpoints. If this +feature is supported by the target, then @value{GDBN} does not +remove breakpoints in order to step over them. This feature +only applies to continue requests. This feature is only available +when the remote stub supports managing breakpoints itself (@pxref{insert +breakpoint or watchpoint packet}). @value{GDBN} assumes that +this feature is applicable to all breakpoint types supported by the stub. + @end table @item qSymbol:: --------------050003060601050504010807--