From: Pedro Alves <palves@redhat.com>
Cc: Jiong Wang <jiwang@tilera.com>, gdb-patches@sourceware.org
Subject: char buf[] -> gdb_byte[] (was: Re: [RFC/TileGX] fix longjmp bug)
Date: Fri, 01 Mar 2013 13:13:00 -0000 [thread overview]
Message-ID: <5130A96E.2040704@redhat.com> (raw)
In-Reply-To: <5130836B.7090505@redhat.com>
On 03/01/2013 10:31 AM, Pedro Alves wrote:
>> > +/* This is the implementation of gdbarch method get_longjmp_target. */
>> > +
>> > +static int
>> > +tilegx_get_longjmp_target (struct frame_info *frame, CORE_ADDR *pc)
>> > +{
>> > + struct gdbarch *gdbarch = get_frame_arch (frame);
>> > + enum bfd_endian byte_order = gdbarch_byte_order (gdbarch);
>> > + CORE_ADDR jb_addr;
>> > + char buf[8];
> s/char/gdb_byte/.
>
BTW, clearly this was a copy paste from some other port.
I'm going through the tree grepping for "char buf[" and
fixing all I find.
--
Pedro Alves
prev parent reply other threads:[~2013-03-01 13:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-01 9:58 [RFC/TileGX] fix longjmp bug Jiong Wang
2013-03-01 10:31 ` Pedro Alves
2013-03-01 10:33 ` Jiong Wang
2013-03-01 13:13 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5130A96E.2040704@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jiwang@tilera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox