Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jiong Wang <jiwang@tilera.com>
To: <gdb-patches@sourceware.org>
Subject: [RFC/TileGX] fix longjmp bug
Date: Fri, 01 Mar 2013 09:58:00 -0000	[thread overview]
Message-ID: <51307BBA.3090202@tilera.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 268 bytes --]

tilegx is lack of get_longjmp_target support.

this patch fix this. please review.

thanks.

gdb/ChangeLog:

         * tilegx-tdep.c (tilegx_get_longjmp_target): New function.
         (tilegx_gdbarch_init): Install it.

-- 
Regards,
Jiong. Wang
Tilera Corporation.


[-- Attachment #2: fix-longjmp.patch --]
[-- Type: text/x-patch, Size: 1681 bytes --]

 ---
 gdb/tilegx-tdep.c |   23 +++++++++++++++++++++++
 1 files changed, 23 insertions(+), 0 deletions(-)

diff --git a/gdb/tilegx-tdep.c b/gdb/tilegx-tdep.c
index 2c4e349..d9a8ed2 100644
--- a/gdb/tilegx-tdep.c
+++ b/gdb/tilegx-tdep.c
@@ -785,6 +785,28 @@ tilegx_in_function_epilogue_p (struct gdbarch *gdbarch, CORE_ADDR pc)
   return 0;
 }
 
+/* This is the implementation of gdbarch method get_longjmp_target.  */
+
+static int
+tilegx_get_longjmp_target (struct frame_info *frame, CORE_ADDR *pc)
+{
+  struct gdbarch *gdbarch = get_frame_arch (frame);
+  enum bfd_endian byte_order = gdbarch_byte_order (gdbarch);
+  CORE_ADDR jb_addr;
+  char buf[8];
+
+  jb_addr = get_frame_register_unsigned (frame, TILEGX_R0_REGNUM);
+
+  /* TileGX jmp_buf contains 32 elements of type __uint_reg_t which
+     is size of 8bytes, the return address is stored in the 25th slot.  */
+  if (target_read_memory (jb_addr +  25 * 8, buf, 8))
+    return 0;
+
+  *pc = extract_unsigned_integer (buf, 8, byte_order);
+
+  return 1;
+}
+
 /* by assigning the 'faultnum' reg in kernel pt_regs with this value,
    kernel do_signal will not check r0. see tilegx kernel/signal.c
    for details.  */
@@ -1030,6 +1052,7 @@ tilegx_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
 
   /* These values and methods are used when gdb calls a target function.  */
   set_gdbarch_push_dummy_call (gdbarch, tilegx_push_dummy_call);
+  set_gdbarch_get_longjmp_target (gdbarch, tilegx_get_longjmp_target);
   set_gdbarch_write_pc (gdbarch, tilegx_write_pc);
   set_gdbarch_breakpoint_from_pc (gdbarch, tilegx_breakpoint_from_pc);
   set_gdbarch_return_value (gdbarch, tilegx_return_value);

             reply	other threads:[~2013-03-01  9:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-01  9:58 Jiong Wang [this message]
2013-03-01 10:31 ` Pedro Alves
2013-03-01 10:33   ` Jiong Wang
2013-03-01 13:13   ` char buf[] -> gdb_byte[] (was: Re: [RFC/TileGX] fix longjmp bug) Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51307BBA.3090202@tilera.com \
    --to=jiwang@tilera.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox