From: Yao Qi <yao@codesourcery.com>
To: Pedro Alves <palves@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/2] Check trace data from trace file
Date: Thu, 28 Feb 2013 01:14:00 -0000 [thread overview]
Message-ID: <512EA836.6070307@codesourcery.com> (raw)
In-Reply-To: <512E24D8.3040206@redhat.com>
On 02/27/2013 11:23 PM, Pedro Alves wrote:
> I'd prefer keeping it actually. It's there to disambiguate with
> the case of the new line of text being a continuation of the previous
> context, that happens to end up on a new line just because that's how the
> text flowed. Like:
>
> (foo_function_foo): New blah foo bar yum foo foo foo.
> Call use_collected_data once on the live target.
>
> What called "use_collected_data"? foo_function_foo, or the top level?
I grep'ed ChangeLog in gdb/testuite, and find "top level" has been used
many times before. I didn't notice this.
>
> Otherwise this version is OK. Thanks.
Committed with the changelog fix.
--
Yao (é½å°§)
next prev parent reply other threads:[~2013-02-28 0:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-25 2:58 Yao Qi
2013-02-25 2:58 ` [PATCH 2/2] Find the next matched trace file in 'tfile target' Yao Qi
2013-02-26 19:53 ` Pedro Alves
2013-02-27 1:37 ` Yao Qi
2013-02-25 3:10 ` [PATCH 1/2] Check trace data from trace file Yao Qi
2013-02-26 18:44 ` Pedro Alves
2013-02-26 18:57 ` Pedro Alves
2013-02-27 1:54 ` Yao Qi
2013-02-27 15:23 ` Pedro Alves
2013-02-28 1:14 ` Yao Qi [this message]
2013-02-25 12:03 ` Abid, Hafiz
2013-02-25 14:10 ` Abid, Hafiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512EA836.6070307@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox