From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9884 invoked by alias); 28 Feb 2013 00:44:33 -0000 Received: (qmail 9840 invoked by uid 22791); 28 Feb 2013 00:44:32 -0000 X-SWARE-Spam-Status: No, hits=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 28 Feb 2013 00:44:27 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1UArbm-0007M0-69 from Yao_Qi@mentor.com ; Wed, 27 Feb 2013 16:44:26 -0800 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Wed, 27 Feb 2013 16:44:25 -0800 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.1.289.1; Wed, 27 Feb 2013 16:44:36 -0800 Message-ID: <512EA836.6070307@codesourcery.com> Date: Thu, 28 Feb 2013 01:14:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Pedro Alves CC: Subject: Re: [PATCH 1/2] Check trace data from trace file References: <1361761061-9625-1-git-send-email-yao@codesourcery.com> <512AD5CA.50606@codesourcery.com> <512D0593.2060501@redhat.com> <512D6702.7020900@codesourcery.com> <512E24D8.3040206@redhat.com> In-Reply-To: <512E24D8.3040206@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00719.txt.bz2 On 02/27/2013 11:23 PM, Pedro Alves wrote: > I'd prefer keeping it actually. It's there to disambiguate with > the case of the new line of text being a continuation of the previous > context, that happens to end up on a new line just because that's how the > text flowed. Like: > > (foo_function_foo): New blah foo bar yum foo foo foo. > Call use_collected_data once on the live target. > > What called "use_collected_data"? foo_function_foo, or the top level? I grep'ed ChangeLog in gdb/testuite, and find "top level" has been used many times before. I didn't notice this. > > Otherwise this version is OK. Thanks. Committed with the changelog fix. -- Yao (齐尧)