From: Pedro Alves <palves@redhat.com>
To: Jiong Wang <jiwang@tilera.com>
Cc: gdb-patches@sourceware.org, Walter Lee <walt@tilera.com>
Subject: Re: [RFC/TileGX 2/2] fix gdbserver bug for 32bit elf
Date: Wed, 27 Feb 2013 14:06:00 -0000 [thread overview]
Message-ID: <512E12DF.9070401@redhat.com> (raw)
In-Reply-To: <512D8B11.7080904@tilera.com>
On 02/27/2013 04:26 AM, Jiong Wang wrote:
>
> at 2013/2/27 2:08, Pedro Alves written:
>> You mention the 'pc' as a pseudo register. At the
>> hardware/kernel level, on tilegx32, is 'pc' 32-bit or 64-bit?
>> I thought Tile-GX was always 64-bit, and tilegx32 was just an ABI.
> thanks for review these.
>
> yes, exactly, TileGX is always 64bit. On tilegx32, at hardware/kernel level, 'pc' is 64bit.
>> Is the kernel already trimming the PC?
> No trimming, the kernel always return 64bit.
Oh well. Makes me feel even more this isn't the best approach, but,
>
> below is the updated ChangeLog, and patch.
>
> please review. thanks.
>
> gdb/
>
> * regformats/reg-tilegx.dat (name): Change abi name to "tilegx".
> * regformats/reg-tilegx32.dat: New.
>
> gdb/gdbserver/
>
> * Makefile.in (clean): Remove reg-tilegx.c, reg-tilegx32.c.
> (reg-tilegx32.c): New rule.
> * configure.srv (tilegx-*-linux*): Add reg-tilegx32.o to srv_regobj.
> * linux-tile-low.c (tile_arch_steup): New function. Invoke
Typo: "setup".
> different register info initializer according to elf class.
> (init_registers_tilgx32): New function. The tilegx32 register info
> initializer.
> (tile_fill_gregset): Use "uint_reg_t" to represent register size.
> (tile_store_gregset): Likewise.
OK.
--
Pedro Alves
next prev parent reply other threads:[~2013-02-27 14:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-05 10:42 Jiong Wang
2013-02-26 18:08 ` Pedro Alves
2013-02-27 4:27 ` Jiong Wang
2013-02-27 14:06 ` Pedro Alves [this message]
2013-02-27 14:10 ` Jiong Wang
2013-02-26 18:24 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512E12DF.9070401@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jiwang@tilera.com \
--cc=walt@tilera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox