From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16437 invoked by alias); 27 Feb 2013 14:06:47 -0000 Received: (qmail 16416 invoked by uid 22791); 27 Feb 2013 14:06:45 -0000 X-SWARE-Spam-Status: No, hits=-8.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_EG X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 27 Feb 2013 14:06:29 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r1RE6SYH025052 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 27 Feb 2013 09:06:28 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r1RE6N1j016925; Wed, 27 Feb 2013 09:06:27 -0500 Message-ID: <512E12DF.9070401@redhat.com> Date: Wed, 27 Feb 2013 14:06:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Jiong Wang CC: gdb-patches@sourceware.org, Walter Lee Subject: Re: [RFC/TileGX 2/2] fix gdbserver bug for 32bit elf References: <5110E21A.2060308@tilera.com> <512CFA08.6060507@redhat.com> <512D8B11.7080904@tilera.com> In-Reply-To: <512D8B11.7080904@tilera.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00680.txt.bz2 On 02/27/2013 04:26 AM, Jiong Wang wrote: > > at 2013/2/27 2:08, Pedro Alves written: >> You mention the 'pc' as a pseudo register. At the >> hardware/kernel level, on tilegx32, is 'pc' 32-bit or 64-bit? >> I thought Tile-GX was always 64-bit, and tilegx32 was just an ABI. > thanks for review these. > > yes, exactly, TileGX is always 64bit. On tilegx32, at hardware/kernel level, 'pc' is 64bit. >> Is the kernel already trimming the PC? > No trimming, the kernel always return 64bit. Oh well. Makes me feel even more this isn't the best approach, but, > > below is the updated ChangeLog, and patch. > > please review. thanks. > > gdb/ > > * regformats/reg-tilegx.dat (name): Change abi name to "tilegx". > * regformats/reg-tilegx32.dat: New. > > gdb/gdbserver/ > > * Makefile.in (clean): Remove reg-tilegx.c, reg-tilegx32.c. > (reg-tilegx32.c): New rule. > * configure.srv (tilegx-*-linux*): Add reg-tilegx32.o to srv_regobj. > * linux-tile-low.c (tile_arch_steup): New function. Invoke Typo: "setup". > different register info initializer according to elf class. > (init_registers_tilgx32): New function. The tilegx32 register info > initializer. > (tile_fill_gregset): Use "uint_reg_t" to represent register size. > (tile_store_gregset): Likewise. OK. -- Pedro Alves