Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Hui Zhu <teawater@gmail.com>
Cc: Hui Zhu <hui_zhu@mentor.com>,
	gdb-patches@sourceware.org,        "Gustavo,
	Luis" <luis_gustavo@mentor.com>
Subject: Re: [PATCH] remote doesn't add the main thread if we didn't do so already
Date: Tue, 26 Feb 2013 14:49:00 -0000	[thread overview]
Message-ID: <512CCB5B.7070801@redhat.com> (raw)
In-Reply-To: <CANFwon3W3f=YQiQcrOXDXPPdS_zaE7kjr=51j=nTNMQ+yGdmaA@mail.gmail.com>

On 02/26/2013 02:39 PM, Hui Zhu wrote:
> Hi Pedro,
> 
> On Tue, Feb 26, 2013 at 8:08 PM, Pedro Alves <palves@redhat.com> wrote:
>> Hi Hui, Luis,
>>
>> Thanks for the patch.
>>
>> On 02/25/2013 11:01 AM, Hui Zhu wrote:
>>> Hi,
>>>
>>> This is the patch to change function add_current_inferior_and_thread that doesn't add the main thread if we didn't do so already.
>>>
>>
>> I have the mild impression I've seen this change before, but heck
>> if I recall any details, and I may be wrong.  Can you or Luis
>> expand on the background/rationale for this change?
> 
> This patch is part of OSE support that includes some small changes and
> some bigger one.  

Okay, that probably explains why I thought I'd seen it before.

> So my thought is  post the small one first.

That's fine, but being small doesn't mean it shouldn't be explained.
Please share the rationale for the change so we have it recorded in
the public archives.  You should be able to find it in Mentor's
internal archives.  What problem does this solve?  When can this
happen (initial connection, vRun, other?).  Etc.

-- 
Pedro Alves


  reply	other threads:[~2013-02-26 14:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-25 11:01 Hui Zhu
2013-02-26 12:08 ` Pedro Alves
2013-02-26 14:40   ` Hui Zhu
2013-02-26 14:49     ` Pedro Alves [this message]
2013-02-27  2:00       ` Hui Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=512CCB5B.7070801@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=hui_zhu@mentor.com \
    --cc=luis_gustavo@mentor.com \
    --cc=teawater@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox