From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27707 invoked by alias); 26 Feb 2013 14:49:15 -0000 Received: (qmail 27689 invoked by uid 22791); 26 Feb 2013 14:49:12 -0000 X-SWARE-Spam-Status: No, hits=-8.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 26 Feb 2013 14:49:03 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r1QEn1G8023860 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 26 Feb 2013 09:49:01 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r1QEmxYv031546; Tue, 26 Feb 2013 09:49:00 -0500 Message-ID: <512CCB5B.7070801@redhat.com> Date: Tue, 26 Feb 2013 14:49:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Hui Zhu CC: Hui Zhu , gdb-patches@sourceware.org, "Gustavo, Luis" Subject: Re: [PATCH] remote doesn't add the main thread if we didn't do so already References: <512B447F.8040309@mentor.com> <512CA5B8.2000706@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00656.txt.bz2 On 02/26/2013 02:39 PM, Hui Zhu wrote: > Hi Pedro, > > On Tue, Feb 26, 2013 at 8:08 PM, Pedro Alves wrote: >> Hi Hui, Luis, >> >> Thanks for the patch. >> >> On 02/25/2013 11:01 AM, Hui Zhu wrote: >>> Hi, >>> >>> This is the patch to change function add_current_inferior_and_thread that doesn't add the main thread if we didn't do so already. >>> >> >> I have the mild impression I've seen this change before, but heck >> if I recall any details, and I may be wrong. Can you or Luis >> expand on the background/rationale for this change? > > This patch is part of OSE support that includes some small changes and > some bigger one. Okay, that probably explains why I thought I'd seen it before. > So my thought is post the small one first. That's fine, but being small doesn't mean it shouldn't be explained. Please share the rationale for the change so we have it recorded in the public archives. You should be able to find it in Mentor's internal archives. What problem does this solve? When can this happen (initial connection, vRun, other?). Etc. -- Pedro Alves