From: Pedro Alves <palves@redhat.com>
To: Marcus Shawcroft <marcus.shawcroft@arm.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdbserver aarch64 fix the clamping of HW break point and watchpoint counts.
Date: Thu, 07 Feb 2013 16:14:00 -0000 [thread overview]
Message-ID: <5113D2E4.3080505@redhat.com> (raw)
In-Reply-To: <5113CD7D.6080502@arm.com>
On 02/07/2013 03:51 PM, Marcus Shawcroft wrote:
> This issue came to light in the recent review of aarch64-linux-nat, and also needs resolving in GDBserver.
>
> OK?
OK.
>
> /Marcus
>
> 2013-02-07 Marcus Shawcroft <marcus.shawcroft@arm.com>
>
> * linux-aarch64-low.c (aarch64_arch_setup): Fix clamping of
> aarch64_num_wp_regs and aarch64_num_bp_regs.
Minor, minor nit: "Fix" is a "why" (which in general may end up wrong in
retrospect), while change log entries record the "what". This would
be more in accordance:
* linux-aarch64-low.c (aarch64_arch_setup): Clamp
aarch64_num_wp_regs and aarch64_num_bp_regs to
AARCH64_HWP_MAX_NUM and AARCH64_HBP_MAX_NUM respectively.
Sorry for being pedant.
--
Pedro Alves
prev parent reply other threads:[~2013-02-07 16:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-07 15:51 Marcus Shawcroft
2013-02-07 16:14 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5113D2E4.3080505@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=marcus.shawcroft@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox