From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30878 invoked by alias); 7 Feb 2013 16:14:55 -0000 Received: (qmail 30804 invoked by uid 22791); 7 Feb 2013 16:14:52 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 07 Feb 2013 16:14:34 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r17GEULl009491 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 7 Feb 2013 11:14:30 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r17GESM0011125; Thu, 7 Feb 2013 11:14:29 -0500 Message-ID: <5113D2E4.3080505@redhat.com> Date: Thu, 07 Feb 2013 16:14:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Marcus Shawcroft CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH] gdbserver aarch64 fix the clamping of HW break point and watchpoint counts. References: <5113CD7D.6080502@arm.com> In-Reply-To: <5113CD7D.6080502@arm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00179.txt.bz2 On 02/07/2013 03:51 PM, Marcus Shawcroft wrote: > This issue came to light in the recent review of aarch64-linux-nat, and also needs resolving in GDBserver. > > OK? OK. > > /Marcus > > 2013-02-07 Marcus Shawcroft > > * linux-aarch64-low.c (aarch64_arch_setup): Fix clamping of > aarch64_num_wp_regs and aarch64_num_bp_regs. Minor, minor nit: "Fix" is a "why" (which in general may end up wrong in retrospect), while change log entries record the "what". This would be more in accordance: * linux-aarch64-low.c (aarch64_arch_setup): Clamp aarch64_num_wp_regs and aarch64_num_bp_regs to AARCH64_HWP_MAX_NUM and AARCH64_HBP_MAX_NUM respectively. Sorry for being pedant. -- Pedro Alves