From: Pedro Alves <palves@redhat.com>
To: Marcus Shawcroft <marcus.shawcroft@arm.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] GDBserver aarch64 support.
Date: Mon, 04 Feb 2013 18:00:00 -0000 [thread overview]
Message-ID: <510FF71A.8070406@redhat.com> (raw)
In-Reply-To: <510FF2A2.4020808@arm.com>
On 02/04/2013 05:40 PM, Marcus Shawcroft wrote:
>>> + /* Find the entry that matches the ADDR and CTRL. */
>>> + for (i = 0; i < num_regs; ++i)
>>> + if (dr_addr_p[i] == addr && dr_ctrl_p[i] == ctrl)
>>> + {
>>> + gdb_assert (dr_ref_count[i] != 0);
>>> + break;
>>
>> "break" after gdb_assert is dead code.
>
> This one matters, it is required in order to terminate the loop early.
Right. I don't know what I was thinking.
> 2013-02-04 Jim MacArthur <jim.macarthur@arm.com>
> Marcus Shawcroft <marcus.shawcroft@arm.com>
> Nigel Stephens <nigel.stephens@arm.com>
> Yufeng Zhang <yufeng.zhang@arm.com>
>
> gdb/
>
> * configure.tgt (aarch64*-*-linux*): Set build_gdbserver=yes.
>
> gdb/gdbserver/
>
> * Makefile.in (clean): Remove aarch64.c and aarch64-without-fpu.c
Missing period at end of sentence.
> (aarch64.c, aarch64-without-fpu.c): New targets.
> * configure.srv (aarch64*-*-linux*): New.
> * linux-aarch64-low.c: New file.
Excellent. This is OK.
--
Pedro Alves
prev parent reply other threads:[~2013-02-04 18:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-04 17:41 Marcus Shawcroft
2013-02-04 18:00 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510FF71A.8070406@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=marcus.shawcroft@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox