From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-98235-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 14307 invoked by alias); 4 Feb 2013 18:00:09 -0000
Received: (qmail 14280 invoked by uid 22791); 4 Feb 2013 18:00:08 -0000
X-SWARE-Spam-Status: No, hits=-7.6 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 04 Feb 2013 17:59:57 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r14Hxt8h018088	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 4 Feb 2013 12:59:55 -0500
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r14Hxs1i031088;	Mon, 4 Feb 2013 12:59:55 -0500
Message-ID: <510FF71A.8070406@redhat.com>
Date: Mon, 04 Feb 2013 18:00:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2
MIME-Version: 1.0
To: Marcus Shawcroft <marcus.shawcroft@arm.com>
CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] GDBserver aarch64 support.
References: <510FF2A2.4020808@arm.com>
In-Reply-To: <510FF2A2.4020808@arm.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-02/txt/msg00085.txt.bz2

On 02/04/2013 05:40 PM, Marcus Shawcroft wrote:

>>> +  /* Find the entry that matches the ADDR and CTRL.  */
>>> +  for (i = 0; i < num_regs; ++i)
>>> +    if (dr_addr_p[i] == addr && dr_ctrl_p[i] == ctrl)
>>> +      {
>>> +    gdb_assert (dr_ref_count[i] != 0);
>>> +    break;
>>
>> "break" after gdb_assert is dead code.
> 
> This one matters, it is required in order to terminate the loop early.

Right.  I don't know what I was thinking.

> 2013-02-04  Jim MacArthur  <jim.macarthur@arm.com>
>             Marcus Shawcroft  <marcus.shawcroft@arm.com>
>             Nigel Stephens  <nigel.stephens@arm.com>
>             Yufeng Zhang  <yufeng.zhang@arm.com>
> 
>     gdb/
> 
>         * configure.tgt (aarch64*-*-linux*): Set build_gdbserver=yes.
> 
>     gdb/gdbserver/
> 
>     * Makefile.in (clean): Remove aarch64.c and aarch64-without-fpu.c

Missing period at end of sentence.

>     (aarch64.c, aarch64-without-fpu.c): New targets.
>     * configure.srv (aarch64*-*-linux*): New.
>     * linux-aarch64-low.c: New file.

Excellent.  This is OK.

-- 
Pedro Alves