Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mircea Gherzan <mircea.gherzan@intel.com>
To: Marc Khouzam <marc.khouzam@ericsson.com>
Cc: "'tromey@redhat.com'" <tromey@redhat.com>,
	 "'vladimir@codesourcery.com'" <vladimir@codesourcery.com>,
	"'gdb-patches@sourceware.org'" <gdb-patches@sourceware.org>
Subject: Re: [RFC] Fix the MI result of -break-insert with multiple locations
Date: Tue, 29 Jan 2013 15:52:00 -0000	[thread overview]
Message-ID: <5107F02F.8070104@intel.com> (raw)
In-Reply-To: <E59706EF8DB1D147B15BECA3322E4BDC0947AB@eusaamb103.ericsson.se>

On 29.01.2013 16:39, Marc Khouzam wrote:
 > The above is an excerpt of the slightly more complete excerpt:
 > body=[bkpt={number="1", ...},{number="1.1", ...},{number="1.2", ...}]
 >
 > and I think this fits with MI grammar:
 > "body" => variable
 > =
 > [bkpt=*] => value which is a list
 > and a list can be composed of many values which can be tuples:
 > {number="1", ...},{number="1.1", ...},{number="1.2", ...}

With a recent snapshot of the master branch [1], here's the full output 
without the patch:

(gdb)
-break-insert foobar
^done,bkpt={number="1",type="breakpoint",disp="keep",enabled="y",addr="<MULTIPLE>",times="0",original-location="foobar"},{number="1.1",enabled="y",addr="0x00000000004008d7",func="foobar()",file="overload.cpp",fullname=".../src/test-bktp-mi-overload/overload.cpp",line="22",thread-groups=["i1"]},{number="1.2",enabled="y",addr="0x00000000004008e0",func="foobar(int)",file="overload.cpp",fullname=".../src/test-bktp-mi-overload/overload.cpp",line="26",thread-groups=["i1"]}
(gdb)

So no square brackets. Therefore not a list and IMHO not a valid MI output.

Thanks,
Mircea

[1] Commit f04df06ec3ee7785676ce4e5e2ee49cf73b286ab


-- 

Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052


  reply	other threads:[~2013-01-29 15:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-29 14:36 Mircea Gherzan
2013-01-29 15:39 ` Marc Khouzam
2013-01-29 15:52   ` Mircea Gherzan [this message]
2013-01-29 16:04     ` Marc Khouzam
2013-01-29 16:26       ` Vladimir Prus
2013-01-29 19:28         ` Mircea Gherzan
2013-01-29 20:36           ` Vladimir Prus
2013-01-29 20:55             ` Mircea Gherzan
2013-01-29 19:45 ` André Pönitz
2013-01-29 20:42   ` Marc Khouzam
2013-01-29 22:14     ` André Pönitz
2013-01-30 16:27       ` Marc Khouzam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5107F02F.8070104@intel.com \
    --to=mircea.gherzan@intel.com \
    --cc=gdb-patches@sourceware.org \
    --cc=marc.khouzam@ericsson.com \
    --cc=tromey@redhat.com \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox