From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24299 invoked by alias); 29 Jan 2013 15:52:36 -0000 Received: (qmail 24286 invoked by uid 22791); 29 Jan 2013 15:52:35 -0000 X-SWARE-Spam-Status: No, hits=-8.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mga09.intel.com (HELO mga09.intel.com) (134.134.136.24) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 29 Jan 2013 15:52:30 +0000 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 29 Jan 2013 07:51:17 -0800 X-ExtLoop1: 1 Received: from mirceagh-mobl.ger.corp.intel.com (HELO [172.28.205.143]) ([172.28.205.143]) by orsmga001.jf.intel.com with ESMTP; 29 Jan 2013 07:52:16 -0800 Message-ID: <5107F02F.8070104@intel.com> Date: Tue, 29 Jan 2013 15:52:00 -0000 From: Mircea Gherzan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/20120907 Thunderbird/15.0.1 MIME-Version: 1.0 To: Marc Khouzam CC: "'tromey@redhat.com'" , "'vladimir@codesourcery.com'" , "'gdb-patches@sourceware.org'" Subject: Re: [RFC] Fix the MI result of -break-insert with multiple locations References: <1359470164-32004-1-git-send-email-mircea.gherzan@intel.com> In-Reply-To: Content-Type: text/plain; charset="iso-8859-1"; format="flowed" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00684.txt.bz2 On 29.01.2013 16:39, Marc Khouzam wrote: > The above is an excerpt of the slightly more complete excerpt: > body=3D[bkpt=3D{number=3D"1", ...},{number=3D"1.1", ...},{number=3D"1.2"= , ...}] > > and I think this fits with MI grammar: > "body" =3D> variable > =3D > [bkpt=3D*] =3D> value which is a list > and a list can be composed of many values which can be tuples: > {number=3D"1", ...},{number=3D"1.1", ...},{number=3D"1.2", ...} With a recent snapshot of the master branch [1], here's the full output=20 without the patch: (gdb) -break-insert foobar ^done,bkpt=3D{number=3D"1",type=3D"breakpoint",disp=3D"keep",enabled=3D"y",= addr=3D"",times=3D"0",original-location=3D"foobar"},{number=3D"1.= 1",enabled=3D"y",addr=3D"0x00000000004008d7",func=3D"foobar()",file=3D"over= load.cpp",fullname=3D".../src/test-bktp-mi-overload/overload.cpp",line=3D"2= 2",thread-groups=3D["i1"]},{number=3D"1.2",enabled=3D"y",addr=3D"0x00000000= 004008e0",func=3D"foobar(int)",file=3D"overload.cpp",fullname=3D".../src/te= st-bktp-mi-overload/overload.cpp",line=3D"26",thread-groups=3D["i1"]} (gdb) So no square brackets. Therefore not a list and IMHO not a valid MI output. Thanks, Mircea [1] Commit f04df06ec3ee7785676ce4e5e2ee49cf73b286ab --=20 Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052