From: Yao Qi <yao@codesourcery.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Don't check PST is NULL in read_symtab
Date: Mon, 14 Jan 2013 12:42:00 -0000 [thread overview]
Message-ID: <50F3DF12.605@codesourcery.com> (raw)
In-Reply-To: <20130111184422.GO6143@adacore.com>
On 01/12/2013 02:44 AM, Joel Brobecker wrote:
>> >(It'd be even better for grepability/readability if the implementations
>> >and hook name agreed, like:
>> >
>> >- result->read_symtab = dbx_psymtab_to_symtab;
>> >+ result->read_symtab = dbx_read_symtab;
>> >
>> >or
>> >
>> >- result->read_symtab = dbx_psymtab_to_symtab;
>> >+ result->psymtab_to_symtab = dbx_psymtab_to_symtab;
> Agree as well. I don't mind making these two changes after Yao's
> commit goes it (unless Yao wants to take care of it, I don't mean
> to cut in).
I'll take care of this in a separate patch.
--
Yao (é½å°§)
prev parent reply other threads:[~2013-01-14 12:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-11 1:57 Yao Qi
2013-01-11 4:52 ` Joel Brobecker
2013-01-11 14:34 ` Tom Tromey
2013-01-11 14:56 ` Yao Qi
2013-01-11 15:06 ` Tom Tromey
2013-01-14 12:42 ` [committed]: " Yao Qi
2013-01-14 12:44 ` Yao Qi
2013-01-11 14:46 ` Yao Qi
2013-01-11 15:06 ` Joel Brobecker
2013-01-11 18:02 ` Pedro Alves
2013-01-11 18:44 ` Joel Brobecker
2013-01-14 12:42 ` Yao Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F3DF12.605@codesourcery.com \
--to=yao@codesourcery.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox