From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7306 invoked by alias); 14 Jan 2013 12:42:45 -0000 Received: (qmail 7298 invoked by uid 22791); 14 Jan 2013 12:42:44 -0000 X-SWARE-Spam-Status: No, hits=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Jan 2013 12:42:37 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1TuhNK-0003jX-TO from Yao_Qi@mentor.com ; Mon, 14 Jan 2013 02:34:42 -0800 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 14 Jan 2013 02:34:42 -0800 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.1.289.1; Mon, 14 Jan 2013 02:34:41 -0800 Message-ID: <50F3DF12.605@codesourcery.com> Date: Mon, 14 Jan 2013 12:42:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Joel Brobecker CC: Pedro Alves , Subject: Re: [PATCH] Don't check PST is NULL in read_symtab References: <1357869440-23451-1-git-send-email-yao@codesourcery.com> <20130111045233.GK6143@adacore.com> <50F025B5.2060203@codesourcery.com> <20130111150537.GM6143@adacore.com> <50F05388.2090408@redhat.com> <20130111184422.GO6143@adacore.com> In-Reply-To: <20130111184422.GO6143@adacore.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00268.txt.bz2 On 01/12/2013 02:44 AM, Joel Brobecker wrote: >> >(It'd be even better for grepability/readability if the implementations >> >and hook name agreed, like: >> > >> >- result->read_symtab = dbx_psymtab_to_symtab; >> >+ result->read_symtab = dbx_read_symtab; >> > >> >or >> > >> >- result->read_symtab = dbx_psymtab_to_symtab; >> >+ result->psymtab_to_symtab = dbx_psymtab_to_symtab; > Agree as well. I don't mind making these two changes after Yao's > commit goes it (unless Yao wants to take care of it, I don't mean > to cut in). I'll take care of this in a separate patch. -- Yao (齐尧)