[RFA 2/2] Make x86-lynx GDBserver pass XML register map to GDB.

[RFA 2/2] Make x86-lynx GDBserver pass XML register map to GDB.

[Joel Brobecker]

This is not strictly needed, since both GDB and GDBserver seem
to agree on the register numbering without this.  But this allows
us to make sure that this is always going to be the case.

gdb/gdbserver/ChangeLog:

        * configure.srv (i[34567]86-*-lynxos*): Set srv_xmlfiles.

Tested on x86-lynx5.  OK to commit?

Thanks,
-- 
Joel

---
 gdb/gdbserver/configure.srv |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/gdb/gdbserver/configure.srv b/gdb/gdbserver/configure.srv
index cb7cfee..cdb5487 100644
--- a/gdb/gdbserver/configure.srv
+++ b/gdb/gdbserver/configure.srv
@@ -105,6 +105,9 @@ case "${target}" in
 			;;
   i[34567]86-*-lynxos*)	srv_regobj="i386.o"
 			srv_tgtobj="lynx-low.o lynx-i386-low.o"
+			srv_xmlfiles="i386/i386.xml"
+			srv_xmlfiles="${srv_xmlfiles} i386/32bit-core.xml"
+			srv_xmlfiles="${srv_xmlfiles} i386/32bit-sse.xml"
 			srv_lynxos=yes
 			;;
   i[34567]86-*-mingw32ce*)
-- 
1.7.0.4

[RFA 1/2] Allow powerpc-*-lynxos* GDBserver to send register map via XML...

[Joel Brobecker]

... back to GDB.  The transfer occurs when GDB sends the
'qXfer:features:read:target.xml' packet.  This allows us to make
sure that GDB and GDBserver use the same register numbering.
This will be important on Lynx 178, where GDB selects the rs6000:6000
architecture by default instead of the powerpc:common architecture.

gdb/gdbserver/ChangeLog:

        * configure.srv (powerpc-*-lynxos*): Set srv_xmlfiles.

Tested on ppc-lynx5.  OK to commit?

Thanks,
-- 
Joel

---
 gdb/gdbserver/configure.srv |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/gdb/gdbserver/configure.srv b/gdb/gdbserver/configure.srv
index d1e04a9..cb7cfee 100644
--- a/gdb/gdbserver/configure.srv
+++ b/gdb/gdbserver/configure.srv
@@ -229,6 +229,9 @@ case "${target}" in
 			;;
   powerpc-*-lynxos*)	srv_regobj="powerpc-32.o"
 			srv_tgtobj="lynx-low.o lynx-ppc-low.o"
+			srv_xmlfiles="rs6000/powerpc-32.xml"
+			srv_xmlfiles="${srv_xmlfiles} rs6000/power-core.xml"
+			srv_xmlfiles="${srv_xmlfiles} rs6000/power-fpu.xml"
 			srv_lynxos=yes
 			;;
   s390*-*-linux*)	srv_regobj="s390-linux32.o"
-- 
1.7.0.4

Re: [RFA 2/2] Make x86-lynx GDBserver pass XML register map to GDB.

[Pedro Alves]

On 12/17/2012 11:38 AM, Joel Brobecker wrote:
> This is not strictly needed, since both GDB and GDBserver seem
> to agree on the register numbering without this.  But this allows
> us to make sure that this is always going to be the case.
> 
> gdb/gdbserver/ChangeLog:
> 
>         * configure.srv (i[34567]86-*-lynxos*): Set srv_xmlfiles.
> 
> Tested on x86-lynx5.  OK to commit?

Sure, thanks.

-- 
Pedro Alves

Re: [RFA 1/2] Allow powerpc-*-lynxos* GDBserver to send register map via XML...

[Pedro Alves]

On 12/17/2012 11:38 AM, Joel Brobecker wrote:
> ... back to GDB.  The transfer occurs when GDB sends the
> 'qXfer:features:read:target.xml' packet.  This allows us to make
> sure that GDB and GDBserver use the same register numbering.
> This will be important on Lynx 178, where GDB selects the rs6000:6000
> architecture by default instead of the powerpc:common architecture.
> 
> gdb/gdbserver/ChangeLog:
> 
>         * configure.srv (powerpc-*-lynxos*): Set srv_xmlfiles.
> 
> Tested on ppc-lynx5.  OK to commit?

Sure.

Note however, that xml descriptions can also send
the OSABI.  So if we had new xml descriptions that
did something like:

<!DOCTYPE target SYSTEM "gdb-target.dtd">
<target>
  <osabi>Lynx178 (or whatever it is)</osabi>
  <xi:include href="..."/>
</target>

and send _that_, then GDB sets the OSABI from
the target, even if you attach without a binary.
This is the modern version of the default OSABI
setting in the end of gdb/configure.tgt, which
I now notice doesn't have a Lynx setting, so
ignore I mentioned it.  :-)

-- 
Pedro Alves

Re: [RFA 2/2] Make x86-lynx GDBserver pass XML register map to GDB.

[Joel Brobecker]

> > gdb/gdbserver/ChangeLog:
> > 
> >         * configure.srv (i[34567]86-*-lynxos*): Set srv_xmlfiles.

> Sure, thanks.

Checked in as well.

-- 
Joel

Re: [RFA 1/2] Allow powerpc-*-lynxos* GDBserver to send register map via XML...

[Joel Brobecker]

> > gdb/gdbserver/ChangeLog:
> > 
> >         * configure.srv (powerpc-*-lynxos*): Set srv_xmlfiles.
> 
> Sure.

Thank you! Checked in.

> Note however, that xml descriptions can also send
> the OSABI.  So if we had new xml descriptions that
> did something like:
[...]
> I now notice doesn't have a Lynx setting, so
> ignore I mentioned it.  :-)

/me loves ignoring interesting bits like these :-).

Thanks, Pedro.
-- 
Joel