Re: as is: mips-tdep long doubles...

[Pedro Alves <palves@redhat.com>]

On 01/01/2013 02:37 PM, Joel Brobecker wrote:
>> Attached is a patch that might be interesting to people who are still
>> running GDB on mips-irix... As the FIXME suggests, it is not perfect,
>> but it helps. Since I will probably never find the time to improve it,
>> I thought I'd just publish the patch here, in case someone could use it
>> too.
> 
> Please ignore this. It was sent by my evil twin.

The good twin sent a ChangeLog entry only.  :-)

> 
> I think that the following patch takes care of everything (the diff
> I sent wasn't even connecting the new definitions):
> 
> commit a14ee758af464230ab40c1a0d9adb4c7db34a9fc
> Author: Joseph Myers <jsm@polyomino.org.uk>
> Date:   Thu Nov 8 00:08:48 2007 +0000
> 
>     include:
>     2007-11-07  Joseph Myers  <joseph@codesourcery.com>
>             Daniel Jacobowitz  <dan@codesourcery.com>
>     
>         * floatformat.h (struct floatformat): Add split_half field.
>         (floatformat_ibm_long_double): New.
>     
>     libiberty:
>     2007-11-07  Joseph Myers  <joseph@codesourcery.com>
>             Daniel Jacobowitz  <dan@codesourcery.com>
>     
>         * floatformat.c (mant_bits_set): New.
>         (floatformat_to_double): Use it.  Note no special handling of
>         split formats.
>         (floatformat_from_double): Note no special handing of split
>         formats.
>         (floatformat_ibm_long_double_is_valid,
>         floatformat_ibm_long_double): New.
>         (floatformat_ieee_single_big, floatformat_ieee_single_little,
>         floatformat_ieee_double_big, floatformat_ieee_double_little,
>         floatformat_ieee_double_littlebyte_bigword, floatformat_vax_f,
>         floatformat_vax_d, floatformat_vax_g, floatformat_i387_ext,
>         floatformat_m68881_ext, floatformat_i960_ext,
>         floatformat_m88110_ext, floatformat_m88110_harris_ext,
>         floatformat_arm_ext_big, floatformat_arm_ext_littlebyte_bigword,
>         floatformat_ia64_spill_big, floatformat_ia64_spill_little,
>         floatformat_ia64_quad_big, floatformat_ia64_quad_little): Update
>         for addition of split_half field.
>     
>     gdb:
>     2007-11-07  Joseph Myers  <joseph@codesourcery.com>
>             Daniel Jacobowitz  <dan@codesourcery.com>
>     
>         * gdbtypes.c (floatformats_ibm_long_double): New.
>         * gdbtypes.h (floatformats_ibm_long_double): Declare.
>         * ia64-tdep.c (floatformat_ia64_ext): Update for addition of
>         split_half field.
>         * mips-tdep.c (n32n64_floatformat_always_valid,
>         floatformat_n32n64_long_double_big, floatformats_n32n64_long):
>         Remove.
>         (mips_gdbarch_init): Use floatformats_ibm_long_double instead of
>         floatformats_n32n64_long.
>         * ppc-linux-tdep.c (ppc_linux_init_abi): Use 128-bit IBM long
>         double.
>         * doublest.c (convert_floatformat_to_doublest,
>         convert_doublest_to_floatformat): Handle split floating-point
>         formats.
>         * ppc-sysv-tdep.c (ppc_sysv_abi_push_dummy_call): Handle IBM long
>         double arguments.
>         (ppc64_sysv_abi_push_dummy_call): Likewise.
>         (do_ppc_sysv_return_value): Handle IBM long double return.
> 
> 
> 


-- 
Pedro Alves