From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8590 invoked by alias); 4 Jan 2013 18:29:56 -0000 Received: (qmail 8576 invoked by uid 22791); 4 Jan 2013 18:29:55 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Jan 2013 18:29:48 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r04ITkjF023874 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 4 Jan 2013 13:29:46 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r04ITih2007763; Fri, 4 Jan 2013 13:29:45 -0500 Message-ID: <50E71F98.3070503@redhat.com> Date: Fri, 04 Jan 2013 18:29:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Joel Brobecker CC: gdb-patches@sourceware.org Subject: Re: as is: mips-tdep long doubles... References: <20130101140252.GB19628@adacore.com> <20130101143742.GC19628@adacore.com> In-Reply-To: <20130101143742.GC19628@adacore.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00072.txt.bz2 On 01/01/2013 02:37 PM, Joel Brobecker wrote: >> Attached is a patch that might be interesting to people who are still >> running GDB on mips-irix... As the FIXME suggests, it is not perfect, >> but it helps. Since I will probably never find the time to improve it, >> I thought I'd just publish the patch here, in case someone could use it >> too. > > Please ignore this. It was sent by my evil twin. The good twin sent a ChangeLog entry only. :-) > > I think that the following patch takes care of everything (the diff > I sent wasn't even connecting the new definitions): > > commit a14ee758af464230ab40c1a0d9adb4c7db34a9fc > Author: Joseph Myers > Date: Thu Nov 8 00:08:48 2007 +0000 > > include: > 2007-11-07 Joseph Myers > Daniel Jacobowitz > > * floatformat.h (struct floatformat): Add split_half field. > (floatformat_ibm_long_double): New. > > libiberty: > 2007-11-07 Joseph Myers > Daniel Jacobowitz > > * floatformat.c (mant_bits_set): New. > (floatformat_to_double): Use it. Note no special handling of > split formats. > (floatformat_from_double): Note no special handing of split > formats. > (floatformat_ibm_long_double_is_valid, > floatformat_ibm_long_double): New. > (floatformat_ieee_single_big, floatformat_ieee_single_little, > floatformat_ieee_double_big, floatformat_ieee_double_little, > floatformat_ieee_double_littlebyte_bigword, floatformat_vax_f, > floatformat_vax_d, floatformat_vax_g, floatformat_i387_ext, > floatformat_m68881_ext, floatformat_i960_ext, > floatformat_m88110_ext, floatformat_m88110_harris_ext, > floatformat_arm_ext_big, floatformat_arm_ext_littlebyte_bigword, > floatformat_ia64_spill_big, floatformat_ia64_spill_little, > floatformat_ia64_quad_big, floatformat_ia64_quad_little): Update > for addition of split_half field. > > gdb: > 2007-11-07 Joseph Myers > Daniel Jacobowitz > > * gdbtypes.c (floatformats_ibm_long_double): New. > * gdbtypes.h (floatformats_ibm_long_double): Declare. > * ia64-tdep.c (floatformat_ia64_ext): Update for addition of > split_half field. > * mips-tdep.c (n32n64_floatformat_always_valid, > floatformat_n32n64_long_double_big, floatformats_n32n64_long): > Remove. > (mips_gdbarch_init): Use floatformats_ibm_long_double instead of > floatformats_n32n64_long. > * ppc-linux-tdep.c (ppc_linux_init_abi): Use 128-bit IBM long > double. > * doublest.c (convert_floatformat_to_doublest, > convert_doublest_to_floatformat): Handle split floating-point > formats. > * ppc-sysv-tdep.c (ppc_sysv_abi_push_dummy_call): Handle IBM long > double arguments. > (ppc64_sysv_abi_push_dummy_call): Likewise. > (do_ppc_sysv_return_value): Handle IBM long double return. > > > -- Pedro Alves