From: Yao Qi <yao@codesourcery.com>
To: Tom Tromey <tromey@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: RFC: add completion for "set gnutarget"
Date: Fri, 04 Jan 2013 10:59:00 -0000 [thread overview]
Message-ID: <50E6B5EC.5030903@codesourcery.com> (raw)
In-Reply-To: <87zk0q5j4n.fsf@fleche.redhat.com>
On 01/04/2013 12:25 AM, Tom Tromey wrote:
> +/* A completion function for "set gnutarget". */
> +
> +static VEC (char_ptr) *
> +complete_set_gnutarget (struct cmd_list_element *cmd, char *text, char *word)
> +{
> + const char **bfd_targets = bfd_target_list ();
I am wondering whether bfd_target_list returns an invariant. If so, we
don't have to call bfd_target_list every time on completion. We can
compute 'bfd_targets' at beginning and use it in completion.
I may be wrong because my bfd knowledge is very limited. After reading
bfd source for a while, I am still not sure bfd_target_list returns an
invariant for a gdb of a given configuration.
--
Yao (é½å°§)
next prev parent reply other threads:[~2013-01-04 10:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-03 16:25 Tom Tromey
2013-01-04 10:17 ` Joel Brobecker
2013-01-04 10:59 ` Yao Qi [this message]
2013-01-04 14:52 ` Tom Tromey
2013-01-05 0:44 ` Yao Qi
2013-01-14 21:01 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50E6B5EC.5030903@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox