From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25126 invoked by alias); 4 Jan 2013 10:59:41 -0000 Received: (qmail 25118 invoked by uid 22791); 4 Jan 2013 10:59:39 -0000 X-SWARE-Spam-Status: No, hits=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Jan 2013 10:59:33 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1Tr4zs-0006DU-Nd from Yao_Qi@mentor.com ; Fri, 04 Jan 2013 02:59:32 -0800 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Fri, 4 Jan 2013 02:59:32 -0800 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.1.289.1; Fri, 4 Jan 2013 02:59:31 -0800 Message-ID: <50E6B5EC.5030903@codesourcery.com> Date: Fri, 04 Jan 2013 10:59:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Tom Tromey CC: Subject: Re: RFC: add completion for "set gnutarget" References: <87zk0q5j4n.fsf@fleche.redhat.com> In-Reply-To: <87zk0q5j4n.fsf@fleche.redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00065.txt.bz2 On 01/04/2013 12:25 AM, Tom Tromey wrote: > +/* A completion function for "set gnutarget". */ > + > +static VEC (char_ptr) * > +complete_set_gnutarget (struct cmd_list_element *cmd, char *text, char *word) > +{ > + const char **bfd_targets = bfd_target_list (); I am wondering whether bfd_target_list returns an invariant. If so, we don't have to call bfd_target_list every time on completion. We can compute 'bfd_targets' at beginning and use it in completion. I may be wrong because my bfd knowledge is very limited. After reading bfd source for a while, I am still not sure bfd_target_list returns an invariant for a gdb of a given configuration. -- Yao (齐尧)