[patch] Skip gdb.base/kill-after-signal.exp if gdb, nosignals

[patch] Skip gdb.base/kill-after-signal.exp if gdb, nosignals

[Yufeng Zhang]

[-- Attachment #1: Type: text/plain, Size: 451 bytes --]

Hi,

This patch adds check to gdb.base/kill-after-signal.exp to skip the test 
if the board has no support for signals, which is the case in most 
baremetal environment.  This patch follows the existing practice as what 
had been done to gdb.base/signull.exp,sigbpt.exp,etc.

Is it OK?

Thanks,
Yufeng


testsuite/

2012-12-13  Yufeng Zhang  <yufeng.zhang@arm.com>

         * gdb.base/kill-after-signal.exp: Disable if gdb,nosignals.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: test-add-nosignals-check.patch --]
[-- Type: text/x-patch; name=test-add-nosignals-check.patch, Size: 535 bytes --]

diff --git a/gdb/testsuite/gdb.base/kill-after-signal.exp b/gdb/testsuite/gdb.base/kill-after-signal.exp
index 7b70510..91eec2d 100644
--- a/gdb/testsuite/gdb.base/kill-after-signal.exp
+++ b/gdb/testsuite/gdb.base/kill-after-signal.exp
@@ -20,6 +20,11 @@ if { ![can_single_step_to_signal_handler] } {
     return
 }
 
+if [target_info exists gdb,nosignals] {
+    verbose "Skipping kill-after-signal.exp because of nosignals."
+    continue
+}
+
 if [prepare_for_testing ${testfile}.exp ${testfile}] {
     return -1
 }

Re: [patch] Skip gdb.base/kill-after-signal.exp if gdb, nosignals

[Pedro Alves]

On 12/13/2012 07:20 PM, Yufeng Zhang wrote:
> Hi,
> 
> This patch adds check to gdb.base/kill-after-signal.exp to skip the test if the board has no support for signals, which is the case in most baremetal environment.  This patch follows the existing practice as what had been done to gdb.base/signull.exp,sigbpt.exp,etc.
> 
> Is it OK?

Yes, thanks.

-- 
Pedro Alves

Re: [patch] Skip gdb.base/kill-after-signal.exp if gdb, nosignals

[Yufeng Zhang]

Thank you for the review.  Can you help commit the patch please?  I 
don't have the write access.

Many thanks,
Yufeng

On 13/12/12 19:53, Pedro Alves wrote:
> On 12/13/2012 07:20 PM, Yufeng Zhang wrote:
>> Hi,
>>
>> This patch adds check to gdb.base/kill-after-signal.exp to skip the test if the board has no support for signals, which is the case in most baremetal environment.  This patch follows the existing practice as what had been done to gdb.base/signull.exp,sigbpt.exp,etc.
>>
>> Is it OK?
>
> Yes, thanks.
>

Re: [patch] Skip gdb.base/kill-after-signal.exp if gdb, nosignals

[Pedro Alves]

On 12/14/2012 11:03 AM, Yufeng Zhang wrote:
> Thank you for the review.  Can you help commit the patch please?  I don't have the write access.

Done.

-- 
Pedro Alves

Re: [patch] Skip gdb.base/kill-after-signal.exp if gdb, nosignals

[Yao Qi]

On 12/14/2012 07:03 PM, Yufeng Zhang wrote:
> Thank you for the review.  Can you help commit the patch please?  I
> don't have the write access.

IIRC, if you've got the write access to binutils, you should have got 
the write access to gdb as well.

-- 
Yao (齐尧)