From: Pedro Alves <palves@redhat.com>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Fix memory leak in windows_xfer_shared_libraries
Date: Fri, 14 Dec 2012 10:12:00 -0000 [thread overview]
Message-ID: <50CAF521.3040307@redhat.com> (raw)
In-Reply-To: <000301cdd9d0$0db345d0$2919d170$@muller@ics-cnrs.unistra.fr>
On 12/14/2012 07:53 AM, Pierre Muller wrote:
>>> I was also wondering if it would not be better to keep the obstack in
>>> between the two calls, but that would probably require some static
>> variable
>>> :(
>>
>> That'd be fine. We actually do that in some cases in gdbserver, like
>> handle_qxfer_threads and handle_qxfer_traceframe_info. It just didn't
>> look like worth it enough to bother when I initially wrote this.
>
> I was wondering if this would become a problem if we later add support for
> multiple inferior
> for windows-nat
I don't think so.
> I vaguely remember that I tried to achieve this a long time ago...
ISTR you had an archer branch for that and other Windows stuff.
>
> Anyhow, the memory leak is gone at least!
Thanks.
--
Pedro Alves
next prev parent reply other threads:[~2012-12-14 10:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <50c9b7e6.25f2440a.3810.3771SMTPIN_ADDED_BROKEN@mx.google.com>
2012-12-13 20:16 ` Pedro Alves
2012-12-14 7:53 ` Pierre Muller
2012-12-14 10:12 ` Pedro Alves [this message]
2012-12-14 10:26 ` [RFA] Fix other memory leak in solib_target_current_sos Pierre Muller
2012-12-14 10:55 ` Pedro Alves
2012-12-14 13:07 ` [RFA-v2] " Pierre Muller
2012-12-14 13:49 ` Pedro Alves
[not found] ` <43198.6185875305$1355480794@news.gmane.org>
2012-12-14 14:14 ` [RFA] " Tom Tromey
2012-12-14 23:29 ` Pierre Muller
2012-12-13 11:11 [RFA] Fix memory leak in windows_xfer_shared_libraries Pierre Muller
2012-12-13 11:23 ` Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50CAF521.3040307@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox