Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andreas Tobler <andreast-list@fgznet.ch>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] FreeBSD powerpc support
Date: Thu, 13 Dec 2012 20:35:00 -0000	[thread overview]
Message-ID: <50CA3BFE.1060604@fgznet.ch> (raw)
In-Reply-To: <50CA3A0D.50100@redhat.com>

On 13.12.12 21:26, Pedro Alves wrote:
> On 12/13/2012 08:20 PM, Andreas Tobler wrote:
>> On 13.12.12 21:03, Pedro Alves wrote:
>>> On 12/12/2012 08:07 PM, Andreas Tobler wrote:
>>>> If you're ok I try to update the patch with a new file which contains
>>>> the 'common' code for ppc64.
>>>
>>> FAOD, I'm fine with that.
>>
>> Ok. Thinking a bit more about makes me feel that a separate patch would
>> be more clean. Iow, a patch which extracts the 'common' functions from
>> ppc-linux-tdep.c into ppc64-common-tdep.c.
>>
>> Once this is tested (ppc64-linux) and in, I can bring the FreeBSD
>> support on top of it.
>>
>> Mixing these two issues together might cause troubles....
>>
>> Do you agree?
> 
> That's fine, but it'd make sense to see both patches together, so we
> don't have to imagine the uses outside GNU/Linux.  This is where quilt
> or git would pay off a lot for you.

Ok, time to learn something new :)

> The reverse would be fine with me too.  Extract the commonality after
> the FreeBSD patch is in.

That would mean that the FreeBSD patch would need approval first ;)

Anyway, I see what is going best.

Thanks,
Andreas


      reply	other threads:[~2012-12-13 20:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-19 21:44 Andreas Tobler
2012-11-23 19:34 ` Pedro Alves
2012-11-27 17:45   ` Andreas Tobler
2012-12-11 15:48     ` PING " Andreas Tobler
2012-12-11 16:14       ` Pedro Alves
2012-12-11 16:33         ` Andreas Tobler
2012-12-11 20:07     ` Pedro Alves
2012-12-12 20:07       ` Andreas Tobler
2012-12-13 20:04         ` Pedro Alves
2012-12-13 20:20           ` Andreas Tobler
2012-12-13 20:27             ` Pedro Alves
2012-12-13 20:35               ` Andreas Tobler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50CA3BFE.1060604@fgznet.ch \
    --to=andreast-list@fgznet.ch \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox