From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20413 invoked by alias); 13 Dec 2012 20:35:27 -0000 Received: (qmail 19723 invoked by uid 22791); 13 Dec 2012 20:35:23 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.fgznet.ch (HELO smtp.fgznet.ch) (81.92.96.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 13 Dec 2012 20:35:18 +0000 Received: from deuterium.andreas.nets (dhclient-91-190-14-19.flashcable.ch [91.190.14.19]) by smtp.fgznet.ch (8.13.8/8.13.8/Submit_SMTPAUTH) with ESMTP id qBDKZAAb001054; Thu, 13 Dec 2012 21:35:13 +0100 (CET) (envelope-from andreast-list@fgznet.ch) Message-ID: <50CA3BFE.1060604@fgznet.ch> Date: Thu, 13 Dec 2012 20:35:00 -0000 From: Andreas Tobler User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.5; rv:16.0) Gecko/20121026 Thunderbird/16.0.2 MIME-Version: 1.0 To: Pedro Alves CC: gdb-patches@sourceware.org Subject: Re: [PATCH] FreeBSD powerpc support References: <50AAA80B.1000509@fgznet.ch> <50AFCF95.1080809@redhat.com> <50B4FC29.9050006@fgznet.ch> <50C79283.1050608@redhat.com> <50C8E3EA.1050300@fgznet.ch> <50CA34A1.3080606@redhat.com> <50CA3892.3040807@fgznet.ch> <50CA3A0D.50100@redhat.com> In-Reply-To: <50CA3A0D.50100@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00475.txt.bz2 On 13.12.12 21:26, Pedro Alves wrote: > On 12/13/2012 08:20 PM, Andreas Tobler wrote: >> On 13.12.12 21:03, Pedro Alves wrote: >>> On 12/12/2012 08:07 PM, Andreas Tobler wrote: >>>> If you're ok I try to update the patch with a new file which contains >>>> the 'common' code for ppc64. >>> >>> FAOD, I'm fine with that. >> >> Ok. Thinking a bit more about makes me feel that a separate patch would >> be more clean. Iow, a patch which extracts the 'common' functions from >> ppc-linux-tdep.c into ppc64-common-tdep.c. >> >> Once this is tested (ppc64-linux) and in, I can bring the FreeBSD >> support on top of it. >> >> Mixing these two issues together might cause troubles.... >> >> Do you agree? > > That's fine, but it'd make sense to see both patches together, so we > don't have to imagine the uses outside GNU/Linux. This is where quilt > or git would pay off a lot for you. Ok, time to learn something new :) > The reverse would be fine with me too. Extract the commonality after > the FreeBSD patch is in. That would mean that the FreeBSD patch would need approval first ;) Anyway, I see what is going best. Thanks, Andreas