From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [2/2] RFC: build machoread.c in more cases
Date: Thu, 13 Dec 2012 20:03:00 -0000 [thread overview]
Message-ID: <50CA3473.9070803@redhat.com> (raw)
In-Reply-To: <87fw394tl1.fsf@fleche.redhat.com>
On 12/13/2012 07:53 PM, Tom Tromey wrote:
> I noticed that machoread.c is only built for Darwin.
>
> This seems wrong to me. It seems like it should instead be built
> whenever the needed BFD code is built. This is what we do for
> elfread.c.
>
> This patch has two benefits. First, it means building with a Darwin
> target is more possible. Second, it means that --enable-targets=all
> will build machoread.c, leading to fewer chances for build regressions
> there. The is the case I ran into...
>
> Comments?
Looks fine to me.
--
Pedro Alves
next prev parent reply other threads:[~2012-12-13 20:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-13 19:53 Tom Tromey
2012-12-13 20:03 ` Pedro Alves [this message]
2013-01-02 14:54 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50CA3473.9070803@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox