From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26405 invoked by alias); 13 Dec 2012 20:03:06 -0000 Received: (qmail 26380 invoked by uid 22791); 13 Dec 2012 20:03:04 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 13 Dec 2012 20:03:01 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBDK30md027894 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 13 Dec 2012 15:03:00 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qBDK2xed015159; Thu, 13 Dec 2012 15:03:00 -0500 Message-ID: <50CA3473.9070803@redhat.com> Date: Thu, 13 Dec 2012 20:03:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [2/2] RFC: build machoread.c in more cases References: <87fw394tl1.fsf@fleche.redhat.com> In-Reply-To: <87fw394tl1.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00468.txt.bz2 On 12/13/2012 07:53 PM, Tom Tromey wrote: > I noticed that machoread.c is only built for Darwin. > > This seems wrong to me. It seems like it should instead be built > whenever the needed BFD code is built. This is what we do for > elfread.c. > > This patch has two benefits. First, it means building with a Darwin > target is more possible. Second, it means that --enable-targets=all > will build machoread.c, leading to fewer chances for build regressions > there. The is the case I ran into... > > Comments? Looks fine to me. -- Pedro Alves