Re: [PATCH/tilegx] tilegx bug fixes & improvements

[Yao Qi <yao@codesourcery.com>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb18030"; format=flowed, Size: 1731 bytes --]

On 12/06/2012 11:19 PM, Jiong Wang wrote:
>> The problems looks about plt.  I find tilegx port doesn't have a plt
>> >stub unwinder.  I am not sure creating a plt stub unwinder can fix
>> >this problem,
>     I am not quite understand the usage of plt stub unwinder here. i386
> do not append plt stub unwinder also. from my understanding, those plt
> stub can be unwinded as normal frame, like a leaf function, or have I
> misunderstood something?
>

I am not familiar with i386 port.  plt stub unwinder is helpful to 
identify current pc is within the plt stub and dynamic resolver, IIRC. 
It is useful when user type command 'n' to step over function 'printf', 
for example, otherwise, gdb will stop inside printf instead of the next 
line of printf, which is expected.

>> >but it should fix other fails in testsuite.
>      the left failures are mostly about type print issues under gdb.cp
> and gdb.python
>

plt stub unwinder may not help in this case.

>    attachment is the patch to fix above problems
>

Thanks for the fix.  We don't post a delta-patch on top of the reviewed 
patch.  If you updated your patch to address review comments, please 
post the new one instead of the delta part (and one mail for one patch).

> diff --git a/gdb/tilegx-tdep.c b/gdb/tilegx-tdep.c
> index f7e00d7..903bf20 100644
> --- a/gdb/tilegx-tdep.c
> +++ b/gdb/tilegx-tdep.c
> @@ -324,23 +324,27 @@ tilegx_push_dummy_call (struct gdbarch *gdbarch,
>       }
>
>     /* Align SP.  */
> -  stack_dest = (stack_dest + 7) & ~0x7;
> +  stack_dest = align_down(stack_dest, 8);
                                                   ^ A space is missing.

or you can use 'tilegx_frame_align', which was used before you change.

-- 
Yao (ÆëÒ¢)