From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21174 invoked by alias); 7 Dec 2012 02:40:23 -0000 Received: (qmail 21146 invoked by uid 22791); 7 Dec 2012 02:40:21 -0000 X-SWARE-Spam-Status: No, hits=-3.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,MIME_CHARSET_FARAWAY,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,TW_EG X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 07 Dec 2012 02:40:14 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1TgnrJ-0003yx-JP from Yao_Qi@mentor.com ; Thu, 06 Dec 2012 18:40:13 -0800 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 6 Dec 2012 18:40:13 -0800 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.1.289.1; Thu, 6 Dec 2012 18:40:12 -0800 Message-ID: <50C15700.7020400@codesourcery.com> Date: Fri, 07 Dec 2012 02:40:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 MIME-Version: 1.0 To: Jiong Wang CC: , Walter Lee , Subject: Re: [PATCH/tilegx] tilegx bug fixes & improvements References: <50C04269.90304@tilera.com> <50C067CC.2050303@codesourcery.com> <50C0B790.9070509@tilera.com> In-Reply-To: <50C0B790.9070509@tilera.com> Content-Type: text/plain; charset="gb18030"; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00121.txt.bz2 On 12/06/2012 11:19 PM, Jiong Wang wrote: >> The problems looks about plt. I find tilegx port doesn't have a plt >> >stub unwinder. I am not sure creating a plt stub unwinder can fix >> >this problem, > I am not quite understand the usage of plt stub unwinder here. i386 > do not append plt stub unwinder also. from my understanding, those plt > stub can be unwinded as normal frame, like a leaf function, or have I > misunderstood something? > I am not familiar with i386 port. plt stub unwinder is helpful to identify current pc is within the plt stub and dynamic resolver, IIRC. It is useful when user type command 'n' to step over function 'printf', for example, otherwise, gdb will stop inside printf instead of the next line of printf, which is expected. >> >but it should fix other fails in testsuite. > the left failures are mostly about type print issues under gdb.cp > and gdb.python > plt stub unwinder may not help in this case. > attachment is the patch to fix above problems > Thanks for the fix. We don't post a delta-patch on top of the reviewed patch. If you updated your patch to address review comments, please post the new one instead of the delta part (and one mail for one patch). > diff --git a/gdb/tilegx-tdep.c b/gdb/tilegx-tdep.c > index f7e00d7..903bf20 100644 > --- a/gdb/tilegx-tdep.c > +++ b/gdb/tilegx-tdep.c > @@ -324,23 +324,27 @@ tilegx_push_dummy_call (struct gdbarch *gdbarch, > } > > /* Align SP. */ > - stack_dest = (stack_dest + 7) & ~0x7; > + stack_dest = align_down(stack_dest, 8); ^ A space is missing. or you can use 'tilegx_frame_align', which was used before you change. -- Yao (ÆëÒ¢)