Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] partial fix PR 14777: Add abbrev cmd 'fo' for 'forward-search'.
Date: Wed, 28 Nov 2012 10:18:00 -0000	[thread overview]
Message-ID: <50B5E4F4.2000905@redhat.com> (raw)
In-Reply-To: <50B5E2EF.7040707@codesourcery.com>

On 11/28/2012 10:09 AM, Yao Qi wrote:
> On 11/09/2012 12:10 AM, Pedro Alves wrote:
>> These are user visible changes, and if we don't tell users about the
>> change in NEWS, those who have tripped on the docs-not-match-reality
>> issue before will never try the abbreviations again, thinking they
>> don't really work, even though they do now work.  IOW, IMO, this
>> is NEWS worty.
> 
> Pedro, changes in this patch [1] are not user visible, because even without this patch nowadays, the (implicitly defined) abbreviated commands still behave correctly.  This patch [1] is to prevent these abbreviated commands becoming ambiguous in the future.

I see.

> Of course, this is a ping to the patch [1].

> --- a/gdb/breakpoint.c
> +++ b/gdb/breakpoint.c
> @@ -16337,6 +16337,7 @@ Delete specified tracepoints.\n\
>  Arguments are tracepoint numbers, separated by spaces.\n\
>  No argument means delete all tracepoints."),
>  	   &deletelist);
> +  add_alias_cmd ("tr", "tracepoints", no_class, 1, &deletelist);

The command being aliased is class_trace, while the alias is no_class.  Why's that?

-- 
Pedro Alves


  reply	other threads:[~2012-11-28 10:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-07 13:01 Yao Qi
2012-11-07 15:13 ` Joel Brobecker
2012-11-07 16:07   ` Pedro Alves
2012-11-08  9:39   ` Yao Qi
2012-11-08 16:11     ` Pedro Alves
2012-11-28 10:10       ` Yao Qi
2012-11-28 10:18         ` Pedro Alves [this message]
2012-11-28 10:36           ` Yao Qi
2012-11-28 11:10             ` Pedro Alves
2012-11-28 11:57               ` [committed]: " Yao Qi
2012-11-07 16:10 ` Eli Zaretskii
2012-11-09  8:35 ` Yao Qi
2012-11-09  8:43   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50B5E4F4.2000905@redhat.com \
    --to=palves@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox