From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30092 invoked by alias); 28 Nov 2012 10:18:51 -0000 Received: (qmail 30083 invoked by uid 22791); 28 Nov 2012 10:18:50 -0000 X-SWARE-Spam-Status: No, hits=-7.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 28 Nov 2012 10:18:33 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qASAITQ2011678 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 28 Nov 2012 05:18:30 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qASAISZC010572; Wed, 28 Nov 2012 05:18:28 -0500 Message-ID: <50B5E4F4.2000905@redhat.com> Date: Wed, 28 Nov 2012 10:18:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Yao Qi CC: Joel Brobecker , gdb-patches@sourceware.org Subject: Re: [PATCH] partial fix PR 14777: Add abbrev cmd 'fo' for 'forward-search'. References: <1352293267-6640-1-git-send-email-yao@codesourcery.com> <20121107151342.GG5103@adacore.com> <509B7DA5.3040009@codesourcery.com> <509BD985.3040500@redhat.com> <50B5E2EF.7040707@codesourcery.com> In-Reply-To: <50B5E2EF.7040707@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00802.txt.bz2 On 11/28/2012 10:09 AM, Yao Qi wrote: > On 11/09/2012 12:10 AM, Pedro Alves wrote: >> These are user visible changes, and if we don't tell users about the >> change in NEWS, those who have tripped on the docs-not-match-reality >> issue before will never try the abbreviations again, thinking they >> don't really work, even though they do now work. IOW, IMO, this >> is NEWS worty. > > Pedro, changes in this patch [1] are not user visible, because even without this patch nowadays, the (implicitly defined) abbreviated commands still behave correctly. This patch [1] is to prevent these abbreviated commands becoming ambiguous in the future. I see. > Of course, this is a ping to the patch [1]. > --- a/gdb/breakpoint.c > +++ b/gdb/breakpoint.c > @@ -16337,6 +16337,7 @@ Delete specified tracepoints.\n\ > Arguments are tracepoint numbers, separated by spaces.\n\ > No argument means delete all tracepoints."), > &deletelist); > + add_alias_cmd ("tr", "tracepoints", no_class, 1, &deletelist); The command being aliased is class_trace, while the alias is no_class. Why's that? -- Pedro Alves