Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: Hui Zhu <teawater@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, <hui_zhu@mentor.com>,
	<gdb-patches@sourceware.org>
Subject: Re: [PATCH] Add CTF support to GDB [4/4] doc
Date: Wed, 28 Nov 2012 02:44:00 -0000	[thread overview]
Message-ID: <50B57A77.8090006@codesourcery.com> (raw)
In-Reply-To: <CANFwon2E3vG8hMwaVz_+u0spLHPw_qth+BSOWzOVHdi5e3i2_g@mail.gmail.com>

On 11/28/2012 09:40 AM, Hui Zhu wrote:
> --- a/doc/gdb.texinfo
> +++ b/doc/gdb.texinfo
> @@ -12069,7 +12069,7 @@ of trace data, via the @code{target tfil
>   @table @code
>
>   @kindex tsave
> -@item tsave [ -r ] @var{filename}
> +@item tsave [ -r ] [-ctf] @var{filename}

According patch 1/4 (function ctf_save), 'tsave -ctf foo' will save ctf 
files into directory 'foo'.  If so, we have to reflect this in document.

Can we do 'tsave -r -ctf foo'?  IIRC, it is not allowed.

It can be written something like this,

   @item tsave [ -r ] @var{filename}
   @itemx tsave [-ctf] @var{dirname}

> @@ -12089,6 +12095,11 @@ the state of the trace run at the moment
>   as the current trace frame you are examining.  @var{filename} must be
>   on a filesystem accessible to the host.
>
> +@kindex target ctf
> +@kindex ctf
> +@item target ctf @var{filename}
> +Use the file named @var{filename} as a source of CTF trace data.
> +

According to patch 3/4 (function init_ctf_ops), 'target ctf foo' uses 
directory foo instead of file foo.

-- 
Yao (齐尧)


  reply	other threads:[~2012-11-28  2:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-21  1:46 Hui Zhu
2012-11-21 17:37 ` Eli Zaretskii
2012-11-23  2:28   ` Hui Zhu
2012-11-23  7:40     ` Eli Zaretskii
2012-11-27 11:17       ` Hui Zhu
2012-11-27 18:11         ` Eli Zaretskii
2012-11-28  1:40           ` Hui Zhu
2012-11-28  2:44             ` Yao Qi [this message]
2012-11-28  4:56               ` Hui Zhu
     [not found]                 ` <50B5A064.2010007@codesourcery.com>
2012-11-28  5:52                   ` Hui Zhu
2012-11-28 17:40                     ` Eli Zaretskii
2013-01-14 12:26                       ` Hui Zhu
2013-01-14 16:05                         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50B57A77.8090006@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=hui_zhu@mentor.com \
    --cc=teawater@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox