From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-96353-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 1869 invoked by alias); 28 Nov 2012 02:44:48 -0000
Received: (qmail 1846 invoked by uid 22791); 28 Nov 2012 02:44:46 -0000
X-SWARE-Spam-Status: No, hits=-4.5 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL
X-Spam-Check-By: sourceware.org
Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 28 Nov 2012 02:44:42 +0000
Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58])	by relay1.mentorg.com with esmtp 	id 1TdXdf-00076C-Ob from Yao_Qi@mentor.com ; Tue, 27 Nov 2012 18:44:39 -0800
Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675);	 Tue, 27 Nov 2012 18:44:39 -0800
Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.1.289.1; Tue, 27 Nov 2012 18:44:38 -0800
Message-ID: <50B57A77.8090006@codesourcery.com>
Date: Wed, 28 Nov 2012 02:44:00 -0000
From: Yao Qi <yao@codesourcery.com>
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20120911 Thunderbird/15.0.1
MIME-Version: 1.0
To: Hui Zhu <teawater@gmail.com>
CC: Eli Zaretskii <eliz@gnu.org>, <hui_zhu@mentor.com>,	<gdb-patches@sourceware.org>
Subject: Re: [PATCH] Add CTF support to GDB [4/4] doc
References: <50AC324D.7010703@mentor.com> <83r4nmvowo.fsf@gnu.org> <50AEDF18.6090707@mentor.com> <83sj80u5rs.fsf@gnu.org> <CANFwon0LSys6Pk6ww1onvKTbDXdgNrrj+AqYR0DCOood-N_a7g@mail.gmail.com> <83vccqx6hf.fsf@gnu.org> <CANFwon2E3vG8hMwaVz_+u0spLHPw_qth+BSOWzOVHdi5e3i2_g@mail.gmail.com>
In-Reply-To: <CANFwon2E3vG8hMwaVz_+u0spLHPw_qth+BSOWzOVHdi5e3i2_g@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-11/txt/msg00791.txt.bz2

On 11/28/2012 09:40 AM, Hui Zhu wrote:
> --- a/doc/gdb.texinfo
> +++ b/doc/gdb.texinfo
> @@ -12069,7 +12069,7 @@ of trace data, via the @code{target tfil
>   @table @code
>
>   @kindex tsave
> -@item tsave [ -r ] @var{filename}
> +@item tsave [ -r ] [-ctf] @var{filename}

According patch 1/4 (function ctf_save), 'tsave -ctf foo' will save ctf 
files into directory 'foo'.  If so, we have to reflect this in document.

Can we do 'tsave -r -ctf foo'?  IIRC, it is not allowed.

It can be written something like this,

   @item tsave [ -r ] @var{filename}
   @itemx tsave [-ctf] @var{dirname}

> @@ -12089,6 +12095,11 @@ the state of the trace run at the moment
>   as the current trace frame you are examining.  @var{filename} must be
>   on a filesystem accessible to the host.
>
> +@kindex target ctf
> +@kindex ctf
> +@item target ctf @var{filename}
> +Use the file named @var{filename} as a source of CTF trace data.
> +

According to patch 3/4 (function init_ctf_ops), 'target ctf foo' uses 
directory foo instead of file foo.

-- 
Yao (齐尧)