From: Pedro Alves <palves@redhat.com>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: gdb-patches@sourceware.org, rustyBSD@gmx.fr
Subject: Re: [PATCH] Fix readlink calls in GDB
Date: Mon, 26 Nov 2012 15:16:00 -0000 [thread overview]
Message-ID: <50B38790.5090206@redhat.com> (raw)
In-Reply-To: <004401cdcbe4$524136c0$f6c3a440$@muller@ics-cnrs.unistra.fr>
On 11/26/2012 02:42 PM, Pierre Muller wrote:
> Just a question:
> your change doesn't seem to add the terminating '\0'
> in all the calls concerned, is this because it concerns specific
> native files for operating systems that already append the '\0' at the end?
No. That must be done in all operating systems. If you look at the code
that surrounds the lines touched by the patch, you'll find the preexisting
code doing that.
--
Pedro Alves
next prev parent reply other threads:[~2012-11-26 15:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-26 14:20 Pedro Alves
2012-11-26 14:43 ` Pierre Muller
2012-11-26 15:16 ` Pedro Alves [this message]
2012-11-26 15:31 ` Pierre Muller
2012-11-26 16:12 ` Pedro Alves
2012-11-26 16:33 ` Pierre Muller
2012-11-26 16:54 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B38790.5090206@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
--cc=rustyBSD@gmx.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox