From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29578 invoked by alias); 26 Nov 2012 15:16:33 -0000 Received: (qmail 29551 invoked by uid 22791); 26 Nov 2012 15:16:31 -0000 X-SWARE-Spam-Status: No, hits=-7.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 26 Nov 2012 15:16:26 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qAQFFVas030307 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 26 Nov 2012 10:15:31 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qAQFFSTr021078; Mon, 26 Nov 2012 10:15:30 -0500 Message-ID: <50B38790.5090206@redhat.com> Date: Mon, 26 Nov 2012 15:16:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Pierre Muller CC: gdb-patches@sourceware.org, rustyBSD@gmx.fr Subject: Re: [PATCH] Fix readlink calls in GDB References: <20121126142036.10142.97678.stgit@brno.lan> <004401cdcbe4$524136c0$f6c3a440$@muller@ics-cnrs.unistra.fr> In-Reply-To: <004401cdcbe4$524136c0$f6c3a440$@muller@ics-cnrs.unistra.fr> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00654.txt.bz2 On 11/26/2012 02:42 PM, Pierre Muller wrote: > Just a question: > your change doesn't seem to add the terminating '\0' > in all the calls concerned, is this because it concerns specific > native files for operating systems that already append the '\0' at the end? No. That must be done in all operating systems. If you look at the code that surrounds the lines touched by the patch, you'll find the preexisting code doing that. -- Pedro Alves