From: Pedro Alves <palves@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] use gdbarch_addr_bits_remove for entry point address
Date: Mon, 26 Nov 2012 11:57:00 -0000 [thread overview]
Message-ID: <50B3591D.7070401@redhat.com> (raw)
In-Reply-To: <50B0ABF9.1080606@codesourcery.com>
This version is OK, but please fix up the ChangeLog entry.
> 2012-11-24 Daniel Jacobowitz <dan@codesourcery.com>
> Kazu Hirata <kazu@codesourcery.com>
> Yao Qi <yao@codesourcery.com>
>
> * objfiles.c (entry_point_address_query): Move some code ...
> (init_entry_point_info): ... here.
Please be more specific:
* objfiles.c (entry_point_address_query): Call
gdbarch_convert_from_func_ptr_addr and gdbarch_addr_bits_remove
here ...
(init_entry_point_info): ... instead of here.
That's more useful for archaeology.
> * solib-svr4.c (exec_entry_point): Likewise.
"Likewise" here doesn't make sense. Perhaps:
* solib-svr4.c (exec_entry_point): Call gdbarch_addr_bits_remove.
> * symfile.c (generic_load): Call gdbarch_addr_bits_remove on
> the entry address.
--
Pedro Alves
next prev parent reply other threads:[~2012-11-26 11:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 9:36 Yao Qi
2012-11-23 19:58 ` Pedro Alves
2012-11-24 11:14 ` Yao Qi
2012-11-26 11:57 ` Pedro Alves [this message]
2012-11-27 8:12 ` Yao Qi
2012-12-13 12:05 ` crash/regression with ia64 targets (was: "Re: [PATCH] use gdbarch_addr_bits_remove for entry point address") Joel Brobecker
2012-12-13 14:13 ` crash/regression with ia64 targets Yao Qi
2012-12-14 15:33 ` Joel Brobecker
2012-12-13 18:36 ` Pedro Alves
2012-12-14 15:14 ` Joel Brobecker
2012-12-15 13:12 ` checked in: " Joel Brobecker
2012-12-14 15:15 ` Tom Tromey
2012-12-14 15:33 ` Joel Brobecker
2012-12-15 13:14 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B3591D.7070401@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox